Change in coreboot[master]: [WIP] ACPI: Dynamically provide VPD methods with ChromeOS

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Lance Zhao.
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49902 )

Change subject: [WIP] ACPI: Dynamically provide VPD methods with ChromeOS
......................................................................

[WIP] ACPI: Dynamically provide VPD methods with ChromeOS

Show VPD device enabled if either RO_VPD or RW_VPD are present
in FMAP.

Change-Id: I7065bea4b288c689b41cc969989ec6fd87c75f1f
Signed-off-by: Kyösti Mälkki 
---
M src/acpi/dsdt_top.asl
M src/mainboard/google/deltaur/dsdt.asl
M src/mainboard/google/drallion/dsdt.asl
M src/mainboard/google/sarien/dsdt.asl
M src/vendorcode/google/chromeos/acpi/vpd.asl
5 files changed, 6 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/49902/1

diff --git a/src/acpi/dsdt_top.asl b/src/acpi/dsdt_top.asl
index d2fcfa6..e2dc61b 100644
--- a/src/acpi/dsdt_top.asl
+++ b/src/acpi/dsdt_top.asl
@@ -6,4 +6,7 @@
 /* Chrome OS specific */
 #include <vendorcode/google/chromeos/acpi/gnvs.asl>
 #include <vendorcode/google/chromeos/acpi/chromeos.asl>
+
+/* VPD support */
+#include <vendorcode/google/chromeos/acpi/vpd.asl>
 #endif
diff --git a/src/mainboard/google/deltaur/dsdt.asl b/src/mainboard/google/deltaur/dsdt.asl
index 47758d4..7a74843 100644
--- a/src/mainboard/google/deltaur/dsdt.asl
+++ b/src/mainboard/google/deltaur/dsdt.asl
@@ -30,9 +30,6 @@
    	}
    }

-	/* VPD support */
-	#include <vendorcode/google/chromeos/acpi/vpd.asl>
-
    /* Chrome OS Embedded Controller */
    Scope (_SB.PCI0.LPCB)
    {
diff --git a/src/mainboard/google/drallion/dsdt.asl b/src/mainboard/google/drallion/dsdt.asl
index 2de104e..5556c98 100644
--- a/src/mainboard/google/drallion/dsdt.asl
+++ b/src/mainboard/google/drallion/dsdt.asl
@@ -31,11 +31,6 @@
    	#include <variant/acpi/mainboard.asl>
    }

-#if CONFIG(CHROMEOS)
-	/* VPD support */
-	#include <vendorcode/google/chromeos/acpi/vpd.asl>
-#endif
-
    #include <southbridge/intel/common/acpi/sleepstates.asl>

/* Chrome OS Embedded Controller */
diff --git a/src/mainboard/google/sarien/dsdt.asl b/src/mainboard/google/sarien/dsdt.asl
index 027fa08..fd91f64 100644
--- a/src/mainboard/google/sarien/dsdt.asl
+++ b/src/mainboard/google/sarien/dsdt.asl
@@ -31,11 +31,6 @@
    	#include <variant/acpi/mainboard.asl>
    }

-#if CONFIG(CHROMEOS)
-	/* VPD support */
-	#include <vendorcode/google/chromeos/acpi/vpd.asl>
-#endif
-
    #include <southbridge/intel/common/acpi/sleepstates.asl>

#if CONFIG(EC_GOOGLE_WILCO)
diff --git a/src/vendorcode/google/chromeos/acpi/vpd.asl b/src/vendorcode/google/chromeos/acpi/vpd.asl
index a1ea338..7330986 100644
--- a/src/vendorcode/google/chromeos/acpi/vpd.asl
+++ b/src/vendorcode/google/chromeos/acpi/vpd.asl
@@ -12,6 +12,8 @@
 {
    Name (_HID, "GOOG000F")
    Name (_UID, 1)
+
+	/* TBD: Show device disabled if !ROVP && !RWVP. */
    Name (_STA, 0xf)

Name (VOFS, 0x600)	/* Start of VPD header in VPD region */
@@ -26,7 +28,7 @@

/*
     * VLOC() - Return location and length of VPD region in memory.
-	 *          These values must be initialized in GNVS by coreboot.
+	 *          These values must be initialized in CNVS by VBOOT.
     *
     * Returns: Package indicating start and length of region:
     *   [0] = Address of the start of VPD region.