Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85850?usp=email )
Change subject: mb/google/nissa/var/rull: Update 6W and 15W DPTF parameters
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/rull/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85850/comment/69a64b12_45ca0471?usp... :
PS2, Line 309: 4100
It is greater than 100% speed!
Thanks. I checked the table carefully and missed one change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85850?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icaee949fa8b2e990efaf6a118bd3b77784ea4340
Gerrit-Change-Number: 85850
Gerrit-PatchSet: 4
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 08 Jan 2025 05:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com