Change in coreboot[master]: sb/intel/common/firmware: add ifd update option

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Marcello Sylvester Bauer (Code Review)

5 Feb 2020 5 Feb '20

11:02 a.m.

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

sb/intel/common/firmware: add ifd update option

Add a Kconfig option to update the ifd descriptor regions by providing a flashrom layout file.

depends on: https://review.coreboot.org/c/coreboot/+/38711 -> Id3db09291af2bd2e759c283e316afd5da1fb4ca7

Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io --- M src/southbridge/intel/common/firmware/Kconfig M src/southbridge/intel/common/firmware/Makefile.inc 2 files changed, 22 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38719/1

diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index eb63d34..99d99bf 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -38,6 +38,15 @@ default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin" depends on HAVE_IFD_BIN

+config HAVE_IFD_BIN_LAYOUT + bool "update regions using a flashrom layout file" + default false + depends on HAVE_IFD_BIN + +config IFD_BIN_LAYOUT_PATH + string "Path and filename flashrom layout file" + depends on HAVE_IFD_BIN_LAYOUT + config HAVE_ME_BIN bool "Add Intel ME/TXE firmware" depends on HAVE_IFD_BIN diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc index 5f3212f..2fc685e 100644 --- a/src/southbridge/intel/common/firmware/Makefile.inc +++ b/src/southbridge/intel/common/firmware/Makefile.inc @@ -27,6 +27,10 @@ endif

IFD_BIN_PATH := $(CONFIG_IFD_BIN_PATH) +ifeq ($(CONFIG_HAVE_IFD_BIN_LAYOUT),y) +IFD_BIN_PATH := $(obj)/descriptor-new.bin +endif + ifneq ($(call strip_quotes,$(CONFIG_IFD_CHIPSET)),) IFDTOOL_USE_CHIPSET := -p $(CONFIG_IFD_CHIPSET) endif @@ -42,6 +46,15 @@ add_intel_firmware: $(call strip_quotes,$(CONFIG_EC_BIN_PATH)) endif add_intel_firmware: $(obj)/coreboot.pre $(IFDTOOL) +ifeq ($(CONFIG_HAVE_IFD_BIN_LAYOUT),y) + printf " IFDTOOL Update Intel Firmware Descriptor\n" + cp $(CONFIG_IFD_BIN_PATH) $(obj)/descriptor-old.bin + $(objutil)/ifdtool/ifdtool \ + $(IFDTOOL_USE_CHIPSET) \ + -n $(CONFIG_IFD_BIN_LAYOUT_PATH) \ + $(obj)/descriptor-old.bin + mv $(obj)/descriptor-old.bin.new $(obj)/descriptor-new.bin +endif printf " DD Adding Intel Firmware Descriptor\n" dd if=$(IFD_BIN_PATH) \ of=$(obj)/coreboot.pre conv=notrunc >/dev/null 2>&1

Attachments:

attachment.htm (text/html — 5.4 KB)

Show replies by date

Marcello Sylvester Bauer (Code Review)

5 Feb 5 Feb

11:05 a.m.

Hello Patrick Rudolph, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38719

to look at the new patch set (#2).

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

sb/intel/common/firmware: add ifd update option

Add a Kconfig option to update the ifd descriptor regions by providing a flashrom layout file.

depends on: https://review.coreboot.org/c/coreboot/+/38711 -> Id3db09291af2bd2e759c283e316afd5da1fb4ca7

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38719/2

Patrick Rudolph (Code Review)

10 Feb 10 Feb

7:19 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38719/2/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38719/2/src/southbridge/intel/commo... PS2, Line 49: ifeq ($(CONFIG_HAVE_IFD_BIN_LAYOUT),y) please create a new makefile rule for $(obj)/descriptor-new.bin

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Comment-Date: Mon, 10 Feb 2020 07:19:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Marcello Sylvester Bauer (Code Review)

11 Feb 11 Feb

9:48 a.m.

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38719

to look at the new patch set (#3).

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

sb/intel/common/firmware: add ifd update option

Add a Kconfig option to update the ifd descriptor regions by providing a flashrom layout file.

depends on: https://review.coreboot.org/c/coreboot/+/38711 -> Id3db09291af2bd2e759c283e316afd5da1fb4ca7

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38719/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Marcello Sylvester Bauer (Code Review)

9:49 a.m.

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38719/2/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38719/2/src/southbridge/intel/commo... PS2, Line 49: ifeq ($(CONFIG_HAVE_IFD_BIN_LAYOUT),y)

...

please create a new makefile rule for $(obj)/descriptor-new. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 11 Feb 2020 09:49:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

11:21 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 32: $(IFDTOOL) Missing dependencies: $(CONFIG_IFD_BIN_PATH) $(CONFIG_IFD_BIN_LAYOUT_PATH)

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 40: endif Please remove $(obj)/descriptor-old.bin when done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 11 Feb 2020 11:21:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

2:16 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 3:

(6 comments)

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Kconfig:

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 42: update Update

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 47: of

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 31: -new `-new` doesn't carry much information, how about `descriptor-newlayout.bin`? or simply `descriptor.bin`?

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 32: $(IFDTOOL)

...

Missing dependencies: $(CONFIG_IFD_BIN_PATH) $(CONFIG_IFD_BIN_LAYOUT_PATH)

Note that they will need $(strip_quotes ) beforehand.

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 34: $(CONFIG_IFD_BIN_PATH) Could use $< if you make it the first prerequisite.

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 39: $(obj)/descriptor-new.bin Use $@ here to make clear that it's the target.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 11 Feb 2020 14:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Marcello Sylvester Bauer (Code Review)

12 Feb 12 Feb

11:06 a.m.

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38719

to look at the new patch set (#4).

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

sb/intel/common/firmware: add ifd update option

Add a Kconfig option to update the ifd descriptor regions by providing a flashrom layout file.

depends on: https://review.coreboot.org/c/coreboot/+/38711 -> Id3db09291af2bd2e759c283e316afd5da1fb4ca7

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38719/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 4 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Marcello Sylvester Bauer (Code Review)

11:07 a.m.

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 3:

(5 comments)

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 31: -new

...

`-new` doesn't carry much information, how about `descriptor-newlayout.bin`? […]

your right. Due to the fact that the idtool creates a new descriptor at the same path as the old one, it have to be copied to the build path. I will name the target 'descriptor.bin' and will remove the copy process, as soon as https://review.coreboot.org/c/coreboot/+/38828 is merged.

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 32: $(IFDTOOL)

...

Note that they will need $(strip_quotes ) beforehand.

Done

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 34: $(CONFIG_IFD_BIN_PATH)

...

Could use $< if you make it the first prerequisite.

Done

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 39: $(obj)/descriptor-new.bin

...

Use $@ here to make clear that it's the target.

Done

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 40: endif

...

Please remove $(obj)/descriptor-old. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 3 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Feb 2020 11:07:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Marcello Sylvester Bauer (Code Review)

11:10 a.m.

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38719

to look at the new patch set (#5).

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

sb/intel/common/firmware: add ifd update option

Add a Kconfig option to update the ifd descriptor regions by providing a flashrom layout file.

depends on: https://review.coreboot.org/c/coreboot/+/38711 -> Id3db09291af2bd2e759c283e316afd5da1fb4ca7

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38719/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 5 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Marcello Sylvester Bauer (Code Review)

11:10 a.m.

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Kconfig:

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 42: update

...

Update

Done

https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 47:

...

of

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 5 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Feb 2020 11:10:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

6:37 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 5 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Feb 2020 18:37:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

20 Feb 20 Feb

12:31 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 5 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 20 Feb 2020 12:31:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marcello Sylvester Bauer (Code Review)

4 Mar 4 Mar

4:59 p.m.

Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Patrick Rudolph, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38719

to look at the new patch set (#7).

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

sb/intel/common/firmware: add ifd update option

Add a Kconfig option to update the Intel File Descriptor regions by providing a flashrom layout file.

depends on: https://review.coreboot.org/c/coreboot/+/38711 -> Id3db09291af2bd2e759c283e316afd5da1fb4ca7

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/38719/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 7 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Marcello Sylvester Bauer (Code Review)

7 Jan 7 Jan

1:35 p.m.

Marcello Sylvester Bauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38719 )

Change subject: sb/intel/common/firmware: add ifd update option ......................................................................

Abandoned

obsolete

-- To view, visit https://review.coreboot.org/c/coreboot/+/38719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41914f83aca443551b93f6e44b3aa975076accbe Gerrit-Change-Number: 38719 Gerrit-PatchSet: 8 Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io Gerrit-Reviewer: Martin Roth - Personal martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

1056

days inactive

1758

days old

coreboot-gerrit@coreboot.org

14 comments

3 participants

tags (0)

participants (3)

Marcello Sylvester Bauer (Code Review)
Nico Huber (Code Review)
Patrick Rudolph (Code Review)