[M] Change in coreboot[master]: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM

[Subrata Banik (Code Review)]

Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Sridhar Siricilla, Arthur Heymans.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )

Change subject: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM
......................................................................

Patch Set 16:

(1 comment)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/74256/comment/59672011_8ed82308 
PS16, Line 1250: if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE) && !s3wake) {
               : 		timestamp_add_now(TS_CSE_FW_SYNC_START);
               : 		cse_fw_sync();
               : 		timestamp_add_now(TS_CSE_FW_SYNC_END);
               : 
               : 		if (CONFIG(SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION))
               : 			store_cse_rw_fw_version();
               : 	}
               : }
> > > The codeflow is quite confusing...  Can't you add store_cse_rw_fw_version in the same function call? Those functions for SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE and SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE look close to identical
> >
> > why function call ? inside cse_fw_sync?
>
> *which

the major dependency to store the cse fw version is cse_fw_sync, which has to be performed prior to the store operation hence, used different boot state machine callbacks

for cse_fw_sync at romstage, we can store it any where post that stage (after cbmem is online).

for cse_fw_sync at ramstage, i have stored immediately after performing the sync operation.