Change in coreboot[master]: Use the fallthrough statement in switch loops - coreboot-gerrit

15 Mar 2021


      Attention is currently required from: Julius Werner, Arthur Heymans, Patrick Rudolph, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51498 )
Change subject: Use the fallthrough statement in switch loops
......................................................................
Patch Set 2:
(2 comments)
File src/console/vtxprintf.c:
https://review.coreboot.org/c/coreboot/+/51498/comment/db27ecc8_01e3872b 
PS2, Line 7: #include <commonlib/bsd/compiler.h>
Shouldn't need to include this header: https://doc.coreboot.org/contributing/coding_style.html#headers-and-includes
https://review.coreboot.org/c/coreboot/+/51498/comment/ff5b47e0_4a9d4bc8 
PS2, Line 256: fallthrough
break
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51498
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcbe373be33ef7247548f856bfaba7ceb7f749b5
Gerrit-Change-Number: 51498
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 15 Mar 2021 14:19:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment