Attention is currently required from: Martin Roth, Karthik Ramasubramanian, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed ......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56818/comment/a5c56781_b6cd0d1b PS2, Line 84: if (CONFIG(EM100)) : fch_spi_config_em100_modes(); : else : fch_spi_config_mb_modes();
Do you realize that EFS only configures some of the speeds, not all of them? […]
Felix commented on https://review.coreboot.org/c/coreboot/+/56645/comment/95dbc5d7_51464870/ that normal speed might have to be different than fast speed. If that is the case, I think it is better to have all of this in Kconfig and use required configs from the respective places:
1. Read mode, Fast speed --> Define in Kconfig, part of EFS, coreboot configures using EFS. 2. TPM speed, Normal speed --> Define in Kconfig, coreboot configures using Kconfig. 3. AltIO speed --> If this has to be the same as fast speed, then it can follow #1.
Basically, all configs can be defined in Kconfig by mainboard user. Common code can take care of managing that and using it appropriately.