Attention is currently required from: Martin Roth, Karthik Ramasubramanian, Felix Held.
1 comment:
File src/soc/amd/common/block/spi/fch_spi.c:
if (CONFIG(EM100))
fch_spi_config_em100_modes();
else
fch_spi_config_mb_modes();
> Do you realize that EFS only configures some of the speeds, not all of them? […]
Felix commented on https://review.coreboot.org/c/coreboot/+/56645/comment/95dbc5d7_51464870/ that normal speed might have to be different than fast speed. If that is the case, I think it is better to have all of this in Kconfig and use required configs from the respective places:
1. Read mode, Fast speed --> Define in Kconfig, part of EFS, coreboot configures using EFS.
2. TPM speed, Normal speed --> Define in Kconfig, coreboot configures using Kconfig.
3. AltIO speed --> If this has to be the same as fast speed, then it can follow #1.
Basically, all configs can be defined in Kconfig by mainboard user. Common code can take care of managing that and using it appropriately.
To view, visit change 56818. To unsubscribe, or for help writing mail filters, visit settings.