Change in coreboot[master]: mb/google/stout: Do not overwrite pei_data

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43028 )

Change subject: mb/google/stout: Do not overwrite pei_data
......................................................................

mb/google/stout: Do not overwrite pei_data

Most of the values are already set in northbridge code.

Change-Id: Ic3c8d23958cb821b8c551415ebb95e934de43e0b
Signed-off-by: Angel Pons 
---
M src/mainboard/google/stout/early_init.c
1 file changed, 28 insertions(+), 50 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43028/1

diff --git a/src/mainboard/google/stout/early_init.c b/src/mainboard/google/stout/early_init.c
index e71d0ee..b9801f2 100644
--- a/src/mainboard/google/stout/early_init.c
+++ b/src/mainboard/google/stout/early_init.c
@@ -89,57 +89,35 @@

void mainboard_fill_pei_data(struct pei_data *pei_data)
 {
-	struct pei_data pei_data_template = {
-		.pei_version = PEI_VERSION,
-		.mchbar = (uintptr_t)DEFAULT_MCHBAR,
-		.dmibar = (uintptr_t)DEFAULT_DMIBAR,
-		.epbar = DEFAULT_EPBAR,
-		.pciexbar = CONFIG_MMCONF_BASE_ADDRESS,
-		.smbusbar = SMBUS_IO_BASE,
-		.wdbbar = 0x4000000,
-		.wdbsize = 0x1000,
-		.hpet_address = CONFIG_HPET_ADDRESS,
-		.rcba = (uintptr_t)DEFAULT_RCBABASE,
-		.pmbase = DEFAULT_PMBASE,
-		.gpiobase = DEFAULT_GPIOBASE,
-		.thermalbase = 0xfed08000,
-		.system_type = 0, // 0 Mobile, 1 Desktop/Server
-		.tseg_size = CONFIG_SMM_TSEG_SIZE,
-		.spd_addresses = { 0xA0, 0x00,0xA4,0x00 },
-		.ts_addresses = { 0x00, 0x00, 0x00, 0x00 },
-		.ec_present = 1,
-		// 0 = leave channel enabled
-		// 1 = disable dimm 0 on channel
-		// 2 = disable dimm 1 on channel
-		// 3 = disable dimm 0+1 on channel
-		.dimm_channel0_disabled = 2,
-		.dimm_channel1_disabled = 2,
-		.max_ddr3_freq = 1600,
-		.usb_port_config = {
-			/* enabled   USB oc pin    length */
-			{ 1, 0, 0x0040 }, /* P0: USB 3.0 1  (OC0) */
-			{ 1, 0, 0x0040 }, /* P1: USB 3.0 2  (OC0) */
-			{ 0, 1, 0x0000 }, /* P2: Empty */
-			{ 1, 1, 0x0040 }, /* P3: Camera (no OC) */
-			{ 1, 1, 0x0040 }, /* P4: WLAN   (no OC) */
-			{ 1, 1, 0x0040 }, /* P5: WWAN   (no OC) */
-			{ 0, 1, 0x0000 }, /* P6: Empty */
-			{ 0, 1, 0x0000 }, /* P7: Empty */
-			{ 0, 5, 0x0000 }, /* P8: Empty */
-			{ 1, 4, 0x0040 }, /* P9: USB 2.0 (AUO4) (OC4) */
-			{ 0, 5, 0x0000 }, /* P10: Empty */
-			{ 0, 5, 0x0000 }, /* P11: Empty */
-			{ 0, 5, 0x0000 }, /* P12: Empty */
-			{ 1, 5, 0x0040 }, /* P13: Bluetooth (no OC) */
-		},
-		.usb3 = {
-			.mode = XHCI_MODE,
-			.hs_port_switch_mask = XHCI_PORTS,
-			.preboot_support = XHCI_PREBOOT,
-			.xhci_streams = XHCI_STREAMS,
-		},
+	pei_data->system_type   = 0; /* 0 Mobile, 1 Desktop/Server */
+	pei_data->ec_present    = 1;
+	pei_data->spd_addresses = { 0xA0, 0x00, 0xA4, 0x00 };
+	pei_data->max_ddr3_freq = 1600;
+
+	pei_data->usb_port_config = {
+		/* enabled   USB oc pin    length */
+		{ 1, 0, 0x0040 }, /* P0: USB 3.0 1  (OC0) */
+		{ 1, 0, 0x0040 }, /* P1: USB 3.0 2  (OC0) */
+		{ 0, 1, 0x0000 }, /* P2: Empty */
+		{ 1, 1, 0x0040 }, /* P3: Camera (no OC) */
+		{ 1, 1, 0x0040 }, /* P4: WLAN   (no OC) */
+		{ 1, 1, 0x0040 }, /* P5: WWAN   (no OC) */
+		{ 0, 1, 0x0000 }, /* P6: Empty */
+		{ 0, 1, 0x0000 }, /* P7: Empty */
+		{ 0, 5, 0x0000 }, /* P8: Empty */
+		{ 1, 4, 0x0040 }, /* P9: USB 2.0 (AUO4) (OC4) */
+		{ 0, 5, 0x0000 }, /* P10: Empty */
+		{ 0, 5, 0x0000 }, /* P11: Empty */
+		{ 0, 5, 0x0000 }, /* P12: Empty */
+		{ 1, 5, 0x0040 }, /* P13: Bluetooth (no OC) */
    };
-	*pei_data = pei_data_template;
+
+	pei_data->usb3 = {
+		.mode = XHCI_MODE,
+		.hs_port_switch_mask = XHCI_PORTS,
+		.preboot_support = XHCI_PREBOOT,
+		.xhci_streams = XHCI_STREAMS,
+	};
 }

void mainboard_early_init(int s3resume)

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43028 )

Change subject: mb/google/stout: Do not overwrite pei_data
......................................................................

Abandoned