Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56701 )
Change subject: soc/amd/common/block/gpio_banks/gpio: use unsigned types where needed ......................................................................
soc/amd/common/block/gpio_banks/gpio: use unsigned types where needed
Use unsigned integers for variables that aren't supposed to become negative.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I5ee037221b9818b0474fe0376323e522c1b3b516 --- M src/soc/amd/common/block/gpio_banks/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/56701/1
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c index 982b240..08621c0 100644 --- a/src/soc/amd/common/block/gpio_banks/gpio.c +++ b/src/soc/amd/common/block/gpio_banks/gpio.c @@ -298,10 +298,10 @@ } }
-static void check_gpios(uint32_t wake_stat, int bit_limit, gpio_t gpio_base, +static void check_gpios(uint32_t wake_stat, unsigned int bit_limit, gpio_t gpio_base, struct gpio_wake_state *state) { - int i; + unsigned int i; gpio_t begin; gpio_t end;
@@ -341,8 +341,8 @@ { const struct chipset_power_state *ps; const struct gpio_wake_state *state; - int i; - int end; + unsigned int i; + unsigned int end;
if (acpi_pm_state_for_elog(&ps) < 0) return;