Change in coreboot[master]: device/pci: Reduce scope of dev_find_slot()

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

device/pci: Reduce scope of dev_find_slot()

We only keep it around because amdfam10 does not yet
work correctly without it.

Change-Id: I3ea37c097bbcc3cf5c0574c7d727eae4f5bee307
Signed-off-by: Kyösti Mälkki 
---
M src/device/device_const.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/34084/1

diff --git a/src/device/device_const.c b/src/device/device_const.c
index c1b0b06..691cd80 100644
--- a/src/device/device_const.c
+++ b/src/device/device_const.c
@@ -35,6 +35,8 @@
  * @param devfn A device/function number.
  * @return Pointer to the device structure (if found), 0 otherwise.
  */
+
+#if CONFIG(NORTHBRIDGE_AMD_AMDFAM10)
 DEVTREE_CONST struct device *dev_find_slot(unsigned int bus,
    					unsigned int devfn)
 {
@@ -51,6 +53,7 @@
    }
    return result;
 }
+#endif

/**
  * Given a Device Path Type, find the device structure.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG@9 
PS2, Line 9: amdfam10 does not yet
           : work correctly without it
Why so?

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Patch Set 2: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG@9 
PS2, Line 9: amdfam10 does not yet
           : work correctly without it
> Why so?

It's either trying to access PCI devices that gets disabled or something still more whacky with HyperTransport.

Nowadays, with more of PCI inlined, I should be able to pinpoint the offending lines with preprocessor __file__, __line__.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Patch Set 2: Code-Review-2

Let's have this on hold until we can decide on soc/intel trouble.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34084/2//COMMIT_MSG@9 
PS2, Line 9: amdfam10 does not yet
           : work correctly without it
> It's either trying to access PCI devices that gets disabled or something still more whacky with Hype […]

Ack, thanks for the explanation. Good to know since I got KFSN4-DRE with dual amdfam10 :)

[Kyösti Mälkki (Code Review)]

Hello Angel Pons, Paul Menzel, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34084

to look at the new patch set (#3).

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

device/pci: Reduce scope of dev_find_slot()

We only keep it around because soc/intel debugging
still depends on it.

Change-Id: I3ea37c097bbcc3cf5c0574c7d727eae4f5bee307
Signed-off-by: Kyösti Mälkki 
---
M src/device/device_const.c
M src/include/device/device.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/34084/3

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Removed Code-Review-2 by Kyösti Mälkki

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

Patch Set 3: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34084 )

Change subject: device/pci: Reduce scope of dev_find_slot()
......................................................................

device/pci: Reduce scope of dev_find_slot()

We only keep it around because soc/intel debugging
still depends on it.

Change-Id: I3ea37c097bbcc3cf5c0574c7d727eae4f5bee307
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34084
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
---
M src/device/device_const.c
M src/include/device/device.h
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/device/device_const.c b/src/device/device_const.c
index 5a3e89b..c46f283 100644
--- a/src/device/device_const.c
+++ b/src/device/device_const.c
@@ -34,7 +34,8 @@
  * @param devfn A device/function number.
  * @return Pointer to the device structure (if found), 0 otherwise.
  */
-DEVTREE_CONST struct device *dev_find_slot(unsigned int bus,
+
+static DEVTREE_CONST struct device *dev_find_slot(unsigned int bus,
    					unsigned int devfn)
 {
    DEVTREE_CONST struct device *dev, *result;
diff --git a/src/include/device/device.h b/src/include/device/device.h
index b1c1651..abcd0a4 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -306,7 +306,6 @@
  * devices in all_devices singly-linked list as well as the time
  * when this function is called (secondary reflecting topology).
  */
-DEVTREE_CONST struct device *dev_find_slot(unsigned int bus, unsigned int devfn);
 DEVTREE_CONST struct device *pcidev_path_on_root_debug(pci_devfn_t devfn, const char *func);

/* Robust discovery of chip_info. */