Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Robert Chen, Shou-Chieh Hsu.
Paul Menzel has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Fix devicetree_update ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84953/comment/d53ffbb6_f2a70dfd?usp... : PS8, Line 7: Fix devicetree_update Something more specific would be nice.
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/84953/comment/56292731_8aa1cb72?usp... : PS8, Line 14: Unrelated.
https://review.coreboot.org/c/coreboot/+/84953/comment/1a6b5ded_09aa909c?usp... : PS8, Line 36: if (board_version > 0xb) : ext_vr_update(); Before it was run for `board_version < 9`. Is the change in behavior wanted?
https://review.coreboot.org/c/coreboot/+/84953/comment/7917ccc4_0a1701d2?usp... : PS8, Line 38: /* Remove power IC after board version 0xc */ What about 0xf? Should it be mentioned in the comment?
https://review.coreboot.org/c/coreboot/+/84953/comment/53047ae1_535d1884?usp... : PS8, Line 38: /* Remove power IC after board version 0xc */ : if (board_version != 0xa && : board_version != 0xb && : board_version != 0xf) : update_lte_device_drawcia(); : /* board version 0xa, 0xb , 0xf is for drawper unit */ This is not mentioned in the commit message. Could you elaborate?