Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40750 )
Change subject: mb/purism/librem_bdw: Remove PS/2 keyboard driver selection ......................................................................
mb/purism/librem_bdw: Remove PS/2 keyboard driver selection
Most payloads, like GRUB, SeaBIOS and Linux, are able to initialize the PS/2 keyboard themselves, so coreboot does not need to initialize it. Therefore, this option should not be hard-coded for the mainboard, and be left for the user to select.
Change-Id: Iac835d2e7a3232f8e5c76f10984ae3f172f9c0ca Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/purism/librem_bdw/Kconfig 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40750/1
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index 7a8bc22..d9747f5 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -21,11 +21,6 @@ string default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
-config DRIVERS_PS2_KEYBOARD - def_bool y - help - Default PS/2 Keyboard to enabled on this board. - config DRIVERS_UART_8250IO def_bool n help
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40750 )
Change subject: mb/purism/librem_bdw: Remove PS/2 keyboard driver selection ......................................................................
Patch Set 1:
I'll have to check this on both the Broadwell and SKL/KBL Librems
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40750 )
Change subject: mb/purism/librem_bdw: Remove PS/2 keyboard driver selection ......................................................................
Patch Set 1:
Patch Set 1:
I'll have to check this on both the Broadwell and SKL/KBL Librems
In https://review.coreboot.org/c/coreboot/+/13026/ Duncan replied, that without this, the PS/2 keyboard did not work in the payload, but he didn’t have time to check that again.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40750 )
Change subject: mb/purism/librem_bdw: Remove PS/2 keyboard driver selection ......................................................................
Patch Set 1: Code-Review+2
tested ToT on both Librem 13v1 and 15v2, no issues with not including PS2 driver w/SeaBIOS
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40750 )
Change subject: mb/purism/librem_bdw: Remove PS/2 keyboard driver selection ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40750/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40750/1//COMMIT_MSG@11 PS1, Line 11: hard-coded Technically speaking, it's not hard-coded, but only enabled by default. Hard-coded would be if it were selected.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40750 )
Change subject: mb/purism/librem_bdw: Remove PS/2 keyboard driver selection ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40750/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40750/1//COMMIT_MSG@11 PS1, Line 11: hard-coded
Technically speaking, it's not hard-coded, but only enabled by default. […]
Hold on, I missed that it's redefining the option, so it would probably not have a prompt anymore
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40750 )
Change subject: mb/purism/librem_bdw: Remove PS/2 keyboard driver selection ......................................................................
mb/purism/librem_bdw: Remove PS/2 keyboard driver selection
Most payloads, like GRUB, SeaBIOS and Linux, are able to initialize the PS/2 keyboard themselves, so coreboot does not need to initialize it. Therefore, this option should not be hard-coded for the mainboard, and be left for the user to select.
Change-Id: Iac835d2e7a3232f8e5c76f10984ae3f172f9c0ca Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40750 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_bdw/Kconfig 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index 7a8bc22..d9747f5 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -21,11 +21,6 @@ string default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
-config DRIVERS_PS2_KEYBOARD - def_bool y - help - Default PS/2 Keyboard to enabled on this board. - config DRIVERS_UART_8250IO def_bool n help
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Paul Menzel (Code Review)