Kevin Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48651 )
Change subject: mb/google/volteer/variant/lindar: Add SSD D3 cold support ......................................................................
mb/google/volteer/variant/lindar: Add SSD D3 cold support
This patch add SSD D3 cold support for lindar.
BUG=b:172405687 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS.
Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Change-Id: Ie343bbff3bde4ff2a7e89bd384d5661af372b560 --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/48651/1
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb index 2e0c93b..b9e417a 100644 --- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -154,6 +154,14 @@ device pnp 0c09.0 on end end end + device ref pcie_rp9 on + chip soc/intel/common/block/pcie/rtd3 + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A22)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" + register "srcclk_pin" = "0" + device generic 0 on end + end + end device ref pmc hidden # The pmc_mux chip driver is a placeholder for the # PMC.MUX device in the ACPI hierarchy.
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48651 )
Change subject: mb/google/volteer/variant/lindar: Add SSD D3 cold support ......................................................................
Set Ready For Review
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48651
to look at the new patch set (#2).
Change subject: mb/google/volteer/variant/lindar: Add SSD D3 cold support ......................................................................
mb/google/volteer/variant/lindar: Add SSD D3 cold support
This patch add SSD D3 cold support for lindar.
BUG=b:172405687 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS.
Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Change-Id: Ie343bbff3bde4ff2a7e89bd384d5661af372b560 --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/48651/2
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48651
to look at the new patch set (#3).
Change subject: mb/google/volteer/variant/lindar: Add SSD D3 cold support ......................................................................
mb/google/volteer/variant/lindar: Add SSD D3 cold support
This patch add SSD D3 cold support for lindar.
BUG=b:172405687 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS.
Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Change-Id: Ie343bbff3bde4ff2a7e89bd384d5661af372b560 --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/48651/3
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48651
to look at the new patch set (#4).
Change subject: mb/google/volteer/variant/lindar: Add SSD D3 cold support ......................................................................
mb/google/volteer/variant/lindar: Add SSD D3 cold support
This patch add SSD D3 cold support for lindar.
BUG=b:172405687 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS.
Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Change-Id: Ie343bbff3bde4ff2a7e89bd384d5661af372b560 --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/48651/4
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48651 )
Change subject: mb/google/volteer/variant/lindar: Add SSD D3 cold support ......................................................................
Patch Set 4: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48651 )
Change subject: mb/google/volteer/variant/lindar: Add SSD D3 cold support ......................................................................
mb/google/volteer/variant/lindar: Add SSD D3 cold support
This patch add SSD D3 cold support for lindar.
BUG=b:172405687 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS.
Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Change-Id: Ie343bbff3bde4ff2a7e89bd384d5661af372b560 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48651 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb index 70e432d..d3be955 100644 --- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -157,6 +157,14 @@ device pnp 0c09.0 on end end end + device ref pcie_rp9 on + chip soc/intel/common/block/pcie/rtd3 + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A22)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" + register "srcclk_pin" = "0" + device generic 0 on end + end + end device ref pmc hidden # The pmc_mux chip driver is a placeholder for the # PMC.MUX device in the ACPI hierarchy.
-
Hung-Te Lin (Code Review) -
Kevin Chang (Code Review)
-
Tim Wawrzynczak (Code Review)