Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 )
Change subject: src/device: Add MDIO operation
......................................................................
Patch Set 2:
(1 comment)
File src/include/device/mdio.h:
https://review.coreboot.org/c/coreboot/+/69382/comment/3050a04a_a0f4997f
PS1, Line 6: struct device;
I guess we want to not rely on nested includes, right?
You are right. I will leave the include in mdio.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6691f92c4233bc30afc9029840b06f74bb1eb4b2
Gerrit-Change-Number: 69382
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 09 Nov 2022 10:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment