Attention is currently required from: Arthur Heymans, Nico Huber, Philipp Hug, Ron Minnich.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81910?usp=email )
Change subject: commonlib/bsd/lz4_wrapper.c: Fix alignment
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81910/comment/19cce63b_9c7f00fb?usp... :
PS1, Line 18: The coreboot LZ4 decompression code does some misaligned access during
: decompression
Lol, I'm not sure, but it looks like this was broken to work around a […]
I didn't notice that. Your suggestion worked. Thanks. I updated the patch to fix the LZ4 code.
Since RISC-V doesn't mandate support for unaligned access it may be useful to adopt a similar approach like in the Linux kernel and have a HAVE_EFFICIENT_UNALIGNED_ACCESS Kconfig. But anyway that is something for another patch. Let me know what you think.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81910?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id165829bfd35be2bce2bbb019c208a304f627add
Gerrit-Change-Number: 81910
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sun, 16 Jun 2024 21:50:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz