HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40332 )
Change subject: nb/i945: Correct the mask used for FSBPMC4 ......................................................................
nb/i945: Correct the mask used for FSBPMC4
Change-Id: I3e2137523d401ac8b10a4ff58f8ca90fa95c2131 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/40332/1
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 730b56a..8a3cfff 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -2279,13 +2279,11 @@ MCHBAR32(FSBPMC3) &= ~(1 << 13);
reg32 = MCHBAR32(FSBPMC4); - reg32 &= ~(3 << 24); + reg32 &= ~(1 << 24); reg32 |= (2 << 24); MCHBAR32(FSBPMC4) = reg32;
- MCHBAR32(FSBPMC4) |= (1 << 21); - - MCHBAR32(FSBPMC4) |= (1 << 5); + MCHBAR32(FSBPMC4) |= (1 << 21) | (1 << 5);
if ((i945_silicon_revision() < 2)) { /* || cpuid() = 0x6e8 */ /* stepping 0 and 1 or CPUID 6e8 */
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40332
to look at the new patch set (#2).
Change subject: nb/i945: Correct the mask used for FSBPMC4 ......................................................................
nb/i945: Correct the mask used for FSBPMC4
Change-Id: I3e2137523d401ac8b10a4ff58f8ca90fa95c2131 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/40332/2