Change in coreboot[master]: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based pla...

[Shreesh Chhabbi (Code Review)]

Hello Shreesh Chhabbi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/45456

to review the following change.

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based
platforms

Change-Id: I0ff896424ab23dba43075c44eb9b2c2c480ccbfb
Signed-off-by: Shreesh Chhabbi 
---
M src/mainboard/google/volteer/Kconfig.name
M src/soc/intel/tigerlake/Kconfig
2 files changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/45456/1

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index db9d486..4f08d92 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -4,6 +4,7 @@
    bool "-> Delbin"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_ELDRID
    bool "-> Eldrid"
@@ -51,8 +52,10 @@
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select VARIANT_HAS_MIPI_CAMERA
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_VOXEL
    bool "-> Voxel"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig
index d92d496..a722144 100644
--- a/src/soc/intel/tigerlake/Kconfig
+++ b/src/soc/intel/tigerlake/Kconfig
@@ -25,7 +25,7 @@
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select HAVE_SMI_HANDLER
    select IDT_IN_EVERY_STAGE
-	select USE_CAR_NEM_ENHANCED_V2
+	select INTEL_CAR_NEM
    select INTEL_GMA_ACPI
    select INTEL_GMA_ADD_VBT if RUN_FSP_GOP
    select IOAPIC

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45456/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/45456/1/src/mainboard/google/voltee... 
PS1, Line 12: 
Eldrid is building with QS silicon.

https://review.coreboot.org/c/coreboot/+/45456/1/src/mainboard/google/voltee... 
PS1, Line 33: 
Terrador is building with QS silicon.

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

Patch Set 1:

(2 comments)

Thank you for providing the information Nick. I am updating the patch.

https://review.coreboot.org/c/coreboot/+/45456/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/45456/1/src/mainboard/google/voltee... 
PS1, Line 12:
> Eldrid is building with QS silicon.

Ack

https://review.coreboot.org/c/coreboot/+/45456/1/src/mainboard/google/voltee... 
PS1, Line 33:
> Terrador is building with QS silicon.

Ack

[Shreesh Chhabbi (Code Review)]

Hello build bot (Jenkins), Nick Vaccaro, Shreesh Chhabbi, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45456

to look at the new patch set (#2).

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based
platforms

BUG=b:145958015
TEST= Build Volteer Coreboot and boot on Volteer Proto 2 and Delbin.

Change-Id: I0ff896424ab23dba43075c44eb9b2c2c480ccbfb
Signed-off-by: Shreesh Chhabbi 
---
M src/mainboard/google/volteer/Kconfig.name
M src/soc/intel/tigerlake/Kconfig
2 files changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/45456/2

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has uploaded a new patch set (#3) to the change originally created by Shreesh Chhabbi. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based
platforms

BUG=b:145958015
TEST= Build Volteer Coreboot and boot on Volteer Proto 2 and Delbin.

Cq-Depend:chrome-internal-review:3249528
Change-Id: I0ff896424ab23dba43075c44eb9b2c2c480ccbfb
Signed-off-by: Shreesh Chhabbi 
---
M src/mainboard/google/volteer/Kconfig.name
M src/soc/intel/tigerlake/Kconfig
2 files changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/45456/3

[Shreesh Chhabbi (Code Review)]

Hello build bot (Jenkins), Nick Vaccaro, Shreesh Chhabbi, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45456

to look at the new patch set (#4).

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based
platforms

BUG=b:145958015
TEST= Build Volteer coreboot and boot on Volteer Proto 2 and Delbin.

Cq-Depend:chrome-internal-review:3249528
Change-Id: I0ff896424ab23dba43075c44eb9b2c2c480ccbfb
Signed-off-by: Shreesh Chhabbi 
---
M src/mainboard/google/volteer/Kconfig.name
M src/soc/intel/tigerlake/Kconfig
2 files changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/45456/4

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

Patch Set 4:

Hi Tim, Nick, can you please help to review?

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

Patch Set 4: Code-Review+2

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

Patch Set 4:

Hi Patrick, Tim, can we submit this patch if no concerns?

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

Patch Set 4: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based
platforms

BUG=b:145958015
TEST= Build Volteer coreboot and boot on Volteer Proto 2 and Delbin.

Cq-Depend:chrome-internal-review:3249528
Change-Id: I0ff896424ab23dba43075c44eb9b2c2c480ccbfb
Signed-off-by: Shreesh Chhabbi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45456
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Nick Vaccaro 
---
M src/mainboard/google/volteer/Kconfig.name
M src/soc/intel/tigerlake/Kconfig
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nick Vaccaro: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index db9d486..10a9411 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -4,11 +4,13 @@
    bool "-> Delbin"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_ELDRID
    bool "-> Eldrid"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_HALVOR
    bool "-> Halvor"
@@ -29,6 +31,7 @@
    bool "-> Terrador"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_TODOR
    bool "-> Todor"
@@ -51,8 +54,10 @@
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select VARIANT_HAS_MIPI_CAMERA
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_VOXEL
    bool "-> Voxel"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
    select SOC_INTEL_CSE_LITE_SKU
+	select USE_CAR_NEM_ENHANCED_V2
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig
index d92d496..a722144 100644
--- a/src/soc/intel/tigerlake/Kconfig
+++ b/src/soc/intel/tigerlake/Kconfig
@@ -25,7 +25,7 @@
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select HAVE_SMI_HANDLER
    select IDT_IN_EVERY_STAGE
-	select USE_CAR_NEM_ENHANCED_V2
+	select INTEL_CAR_NEM
    select INTEL_GMA_ACPI
    select INTEL_GMA_ADD_VBT if RUN_FSP_GOP
    select IOAPIC

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45456 )

Change subject: mb/volteer: Select USE_CAR_NEM_ENHANCED_V2 for Tigerlake QS based platforms
......................................................................

Patch Set 5:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19743
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19742
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19741
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19740
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19739
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19747
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19746
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19745
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19744

Please note: This test is under development and might not be accurate at all!