Change in coreboot[master]: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Duncan Laurie (Code Review)

25 Mar 2020 25 Mar '20

6:27 p.m.

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39835 )

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU

QEMU does not have a separate northbridge chip, so the mainboard needs to handle the ACPI name and paths so that devices can get generated into the SSDT properly. This fixes the PIRQ and TPM table generation.

Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/emulation/qemu-i440fx/northbridge.c 1 file changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/39835/1

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 7e067a4..de96029 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -229,6 +229,20 @@ return len; } #endif + +#if CONFIG(HAVE_ACPI_TABLES) +static const char *qemu_acpi_name(const struct device *dev) +{ + if (dev->path.type == DEVICE_PATH_DOMAIN) + return "PCI0"; + + if (dev->path.type != DEVICE_PATH_PCI || dev->bus->secondary != 0) + return NULL; + + return NULL; +} +#endif + static struct device_operations pci_domain_ops = { .read_resources = cpu_pci_domain_read_resources, .set_resources = cpu_pci_domain_set_resources, @@ -238,6 +252,9 @@ #if CONFIG(GENERATE_SMBIOS_TABLES) .get_smbios_data = qemu_get_smbios_data, #endif +#if CONFIG(HAVE_ACPI_TABLES) + .acpi_name = qemu_acpi_name, +#endif };

static void cpu_bus_init(struct device *dev)

Attachments:

attachment.htm (text/html — 4.0 KB)

Show replies by date

Furquan Shaikh (Code Review)

25 Mar 25 Mar

6:44 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39835 )

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 25 Mar 2020 17:44:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:38 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39835 )

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39835/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39835/1//COMMIT_MSG@13 PS1, Line 13: Tested how? acpidump? Running some TPM command in QEMU?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 25 Mar 2020 20:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

26 Mar 26 Mar

10:05 p.m.

Hello build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39835

to look at the new patch set (#2).

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU

This issue can be seen in the coreboot output: ACPI_PIRQ_GEN: Missing LPCB ACPI path

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/39835/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Duncan Laurie (Code Review)

10:05 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39835 )

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39835/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39835/1//COMMIT_MSG@13 PS1, Line 13:

...

Tested how? acpidump? Running some TPM command in QEMU?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 26 Mar 2020 21:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

27 Mar 27 Mar

8:59 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39835 )

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 27 Mar 2020 07:59:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:52 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39835 )

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 27 Mar 2020 12:52:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

31 Mar 31 Mar

12:41 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39835 )

Change subject: mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU ......................................................................

mb/emulation/qemu-i440fx: Add acpi_name handler for QEMU

This issue can be seen in the coreboot output: ACPI_PIRQ_GEN: Missing LPCB ACPI path

Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39835 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/emulation/qemu-i440fx/northbridge.c 1 file changed, 17 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 355f13c..74e52de 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -229,6 +229,20 @@ return len; } #endif + +#if CONFIG(HAVE_ACPI_TABLES) +static const char *qemu_acpi_name(const struct device *dev) +{ + if (dev->path.type == DEVICE_PATH_DOMAIN) + return "PCI0"; + + if (dev->path.type != DEVICE_PATH_PCI || dev->bus->secondary != 0) + return NULL; + + return NULL; +} +#endif + static struct device_operations pci_domain_ops = { .read_resources = cpu_pci_domain_read_resources, .set_resources = cpu_pci_domain_set_resources, @@ -238,6 +252,9 @@ #if CONFIG(GENERATE_SMBIOS_TABLES) .get_smbios_data = qemu_get_smbios_data, #endif +#if CONFIG(HAVE_ACPI_TABLES) + .acpi_name = qemu_acpi_name, +#endif };

static void cpu_bus_init(struct device *dev)

-- To view, visit https://review.coreboot.org/c/coreboot/+/39835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7d4359eea38ac0b55d655e39191ae7f8655fe4 Gerrit-Change-Number: 39835 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1690

days inactive

1696

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)