Attention is currently required from: Martin L Roth, Jakub Czapiga, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69893 )
Change subject: commonlib/bsd: Add zstd support
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/bsd/zstd_wrapper.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164282):
https://review.coreboot.org/c/coreboot/+/69893/comment/134c879c_742f6db8
PS2, Line 27: printk(BIOS_ERR, "Bogus free called\n");
Prefer using '"%s...", __func__' to using 'free', this function's name, in a string
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1b1f53327c598d07bd83d4391e8012d41696a16
Gerrit-Change-Number: 69893
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 22 Nov 2022 16:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment