Attention is currently required from: Hung-Te Lin, Rex-BC Chen, flora.fu@mediatek.com. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58969 )
Change subject: soc/mediatek/mt8195: Add APU device apc driver ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58969/comment/3a257007_5ddc826f PS2, Line 9: setup set up
https://review.coreboot.org/c/coreboot/+/58969/comment/e32131dd_0f5bbdf0 PS2, Line 9: Add APU device apc driver and setup permissions. Please elaborate, what the APU device is, and what kind of permissions you mean.
https://review.coreboot.org/c/coreboot/+/58969/comment/51f645d1_d389e810 PS2, Line 13: TEST=boot cherry correctly Please paste the new debug messages, added by the code.
File src/soc/mediatek/mt8195/apusys_devapc.c:
https://review.coreboot.org/c/coreboot/+/58969/comment/38c60f51_2ddf1682 PS2, Line 212: u32 d, i; Please use native types, for example, `size_t` or `unsigned int`, for count variables.
File src/soc/mediatek/mt8195/devapc.c:
https://review.coreboot.org/c/coreboot/+/58969/comment/ca90f884_52a2d381 PS2, Line 1889: Setup Set up