Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78132?usp=email )
Change subject: mb/intel/mtlrvp: Move selects from Kconfig.name to Kconfig ......................................................................
mb/intel/mtlrvp: Move selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files.
Change-Id: If6b666478e15a8e843b50b60be490593349240bd Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/78132 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth gaumless@gmail.com --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Kconfig.name 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index 8a59085..f225aa5 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -26,10 +26,12 @@
config BOARD_INTEL_MTLRVP_P_EXT_EC select BOARD_EXT_EC_SPECIFIC_OPTIONS + select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
config BOARD_INTEL_MTLRVP_P_MCHP select BOARD_EXT_EC_SPECIFIC_OPTIONS select EC_GOOGLE_CHROMEEC_MEC + select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
config BOARD_EXT_EC_SPECIFIC_OPTIONS def_bool n diff --git a/src/mainboard/intel/mtlrvp/Kconfig.name b/src/mainboard/intel/mtlrvp/Kconfig.name index afba1ef..9f61aff 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig.name +++ b/src/mainboard/intel/mtlrvp/Kconfig.name @@ -3,8 +3,6 @@
config BOARD_INTEL_MTLRVP_P_EXT_EC bool "Meteorlake-P RVP with Chrome EC" - select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
config BOARD_INTEL_MTLRVP_P_MCHP bool "Meteorlake-P RVP with Microchip EC" - select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON