Change in coreboot[master]: [WIP] arch/x86: Consolidate ACPI FADT for SMI entries

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42034 )

Change subject: [WIP] arch/x86: Consolidate ACPI FADT for SMI entries
......................................................................

[WIP] arch/x86: Consolidate ACPI FADT for SMI entries

Change-Id: Ia3c976b13508f0cbe4f494eb26c87031abaac459
Signed-off-by: Kyösti Mälkki 
---
M src/acpi/acpi.c
M src/cpu/x86/smm/smi_trigger.c
M src/include/acpi/acpi.h
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
M src/soc/intel/xeon_sp/cpx/acpi.c
M src/soc/intel/xeon_sp/skx/acpi.c
M src/southbridge/amd/agesa/hudson/fadt.c
M src/southbridge/amd/pi/hudson/fadt.c
M src/southbridge/intel/bd82x6x/lpc.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/i82801dx/fadt.c
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801ix/fadt.c
M src/southbridge/intel/i82801jx/lpc.c
M src/southbridge/intel/ibexpeak/lpc.c
M src/southbridge/intel/lynxpoint/lpc.c
22 files changed, 20 insertions(+), 119 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/42034/1

diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c
index 47f03c8..bed4d39 100644
--- a/src/acpi/acpi.c
+++ b/src/acpi/acpi.c
@@ -1262,6 +1262,8 @@
    acpi_fill_fadt(fadt);

soc_fill_fadt(fadt);
+	if (permanent_smi_handler())
+		x86_fill_fadt_smi(fadt);
    mainboard_fill_fadt(fadt);

header->checksum =
diff --git a/src/cpu/x86/smm/smi_trigger.c b/src/cpu/x86/smm/smi_trigger.c
index 586d3ce..54d7661 100644
--- a/src/cpu/x86/smm/smi_trigger.c
+++ b/src/cpu/x86/smm/smi_trigger.c
@@ -50,3 +50,16 @@
    printk(BIOS_DEBUG, ".. done\n");
    return 0;
 }
+
+void x86_fill_fadt_smi(acpi_fadt_t *fadt)
+{
+	fadt->smi_cmd = APM_CNT;
+	fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
+	fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
+
+	if (1)
+		fadt->pstate_cnt = APM_CNT_PST_CONTROL;
+
+	if (1)
+		fadt->cst_cnt = APM_CNT_CST_CONTROL;
+}
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h
index 207e8dc..f0088d6 100644
--- a/src/include/acpi/acpi.h
+++ b/src/include/acpi/acpi.h
@@ -873,6 +873,8 @@
 void soc_fill_fadt(acpi_fadt_t *fadt);
 void mainboard_fill_fadt(acpi_fadt_t *fadt);

+void x86_fill_fadt_smi(acpi_fadt_t *fadt);
+
 void update_ssdt(void *ssdt);
 void update_ssdtx(void *ssdtx, int i);

diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c
index fe5879c..93b23a0 100644
--- a/src/soc/amd/picasso/acpi.c
+++ b/src/soc/amd/picasso/acpi.c
@@ -91,12 +91,6 @@

fadt->sci_int = 9;		/* IRQ 09 - ACPI SCI */

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
    fadt->pm1b_evt_blk = 0x0000;
    fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK;
diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c
index ea67aa3..aed6c49 100644
--- a/src/soc/amd/stoneyridge/acpi.c
+++ b/src/soc/amd/stoneyridge/acpi.c
@@ -63,12 +63,6 @@

fadt->sci_int = 9;		/* IRQ 09 - ACPI SCI */

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
    fadt->pm1b_evt_blk = 0x0000;
    fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK;
diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c
index d008dd8..8137908 100644
--- a/src/soc/intel/baytrail/acpi.c
+++ b/src/soc/intel/baytrail/acpi.c
@@ -129,12 +129,6 @@

fadt->sci_int = acpi_sci_irq();

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + PM1_CNT;
diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c
index 0bac42c..91bb762 100644
--- a/src/soc/intel/braswell/acpi.c
+++ b/src/soc/intel/braswell/acpi.c
@@ -133,12 +133,6 @@

fadt->sci_int = acpi_sci_irq();

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + PM1_CNT;
diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c
index fce2e45..b68bc2a 100644
--- a/src/soc/intel/broadwell/acpi.c
+++ b/src/soc/intel/broadwell/acpi.c
@@ -185,12 +185,6 @@

fadt->sci_int = acpi_sci_irq();

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + PM1_CNT;
diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c
index 4e4906c..e521d4f 100644
--- a/src/soc/intel/common/block/acpi/acpi.c
+++ b/src/soc/intel/common/block/acpi/acpi.c
@@ -97,12 +97,6 @@

fadt->sci_int = acpi_sci_irq();

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + PM1_CNT;
diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index bdfacd3..43f2adc 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -226,12 +226,6 @@

fadt->sci_int = acpi_sci_irq();

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + PM1_CNT;
@@ -249,6 +243,7 @@
    fadt->gpe0_blk_len = 2 * GPE0_REG_MAX * sizeof(uint32_t);
    fadt->gpe1_blk_len = 0;
    fadt->gpe1_base = 0;
+
    fadt->p_lvl2_lat = 1;
    fadt->p_lvl3_lat = 87;
    fadt->flush_size = 1024;
diff --git a/src/soc/intel/xeon_sp/cpx/acpi.c b/src/soc/intel/xeon_sp/cpx/acpi.c
index b090d12..4d76ace 100644
--- a/src/soc/intel/xeon_sp/cpx/acpi.c
+++ b/src/soc/intel/xeon_sp/cpx/acpi.c
@@ -148,12 +148,6 @@

fadt->x_gpe1_blk.space_id = 1;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    /*  General-Purpose Event Registers */
    fadt->x_gpe0_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_gpe0_blk.bit_width = 64; /* EventStatus + EventEnable */
diff --git a/src/soc/intel/xeon_sp/skx/acpi.c b/src/soc/intel/xeon_sp/skx/acpi.c
index 3da2025..ae5c3f8 100644
--- a/src/soc/intel/xeon_sp/skx/acpi.c
+++ b/src/soc/intel/xeon_sp/skx/acpi.c
@@ -333,13 +333,6 @@

fadt->sci_int = acpi_sci_irq();

-	/* TODO: enabled SMM mode switch when SMM handlers are set up. */
-	if (0 && permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + PM1_CNT;
@@ -357,6 +350,7 @@
    fadt->gpe0_blk_len = 2 * GPE0_REG_MAX * sizeof(uint32_t);
    fadt->gpe1_blk_len = 0;
    fadt->gpe1_base = 0;
+
    fadt->p_lvl2_lat = 1;
    fadt->p_lvl3_lat = 87;
    fadt->flush_size = 1024;
diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c
index 719eb54..54da4fa 100644
--- a/src/southbridge/amd/agesa/hudson/fadt.c
+++ b/src/southbridge/amd/agesa/hudson/fadt.c
@@ -29,12 +29,6 @@

fadt->sci_int = 9;		/* HUDSON - IRQ 09 - ACPI SCI */

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = ACPI_SMI_CTL_PORT;
-		fadt->acpi_enable = ACPI_SMI_CMD_ENABLE;
-		fadt->acpi_disable = ACPI_SMI_CMD_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
    fadt->pm1b_evt_blk = 0x0000;
    fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK;
diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c
index 8ed0330..8ff4b43 100644
--- a/src/southbridge/amd/pi/hudson/fadt.c
+++ b/src/southbridge/amd/pi/hudson/fadt.c
@@ -29,12 +29,6 @@

fadt->sci_int = 9;		/* HUDSON - IRQ 09 - ACPI SCI */

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = ACPI_SMI_CTL_PORT;
-		fadt->acpi_enable = ACPI_SMI_CMD_ENABLE;
-		fadt->acpi_disable = ACPI_SMI_CMD_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK;
    fadt->pm1b_evt_blk = 0x0000;
    fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK;
diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c
index 11211c2..c5e4dc3 100644
--- a/src/southbridge/intel/bd82x6x/lpc.c
+++ b/src/southbridge/intel/bd82x6x/lpc.c
@@ -688,12 +688,6 @@

fadt->sci_int = 0x9;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}
-
    fadt->pm1a_evt_blk = pmbase;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + 0x4;
@@ -710,6 +704,7 @@
    fadt->gpe0_blk_len = 16;
    fadt->gpe1_blk_len = 0;
    fadt->gpe1_base = 0;
+
    c2_latency = chip->c2_latency;
    if (!c2_latency) {
    	c2_latency = 101; /* c2 unsupported */
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 84745a4..6e73912 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -20,11 +20,6 @@
 {
    fadt->sci_int = 9;

-	if (permanent_smi_handler()) {
-		/* TODO: SMI handler is not implemented. */
-		fadt->smi_cmd = 0x00;
-	}
-
    fadt->pm1a_evt_blk = DEFAULT_PMBASE;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = DEFAULT_PMBASE + PMCNTRL;
diff --git a/src/southbridge/intel/i82801dx/fadt.c b/src/southbridge/intel/i82801dx/fadt.c
index 2da2175..a27f2c2 100644
--- a/src/southbridge/intel/i82801dx/fadt.c
+++ b/src/southbridge/intel/i82801dx/fadt.c
@@ -24,13 +24,6 @@

fadt->sci_int = 0x9;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = ACPI_ENABLE;
-		fadt->acpi_disable = ACPI_DISABLE;
-		fadt->pstate_cnt = PST_CONTROL;
-	}
-
    fadt->pm1a_evt_blk = pmbase;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + 0x4;
diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c
index 23c391c..53f3e51 100644
--- a/src/southbridge/intel/i82801gx/lpc.c
+++ b/src/southbridge/intel/i82801gx/lpc.c
@@ -507,14 +507,6 @@

fadt->sci_int = 0x9;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-		fadt->pstate_cnt = APM_CNT_PST_CONTROL;
-		fadt->cst_cnt = APM_CNT_CST_CONTROL;
-	}
-
    fadt->p_lvl2_lat = 1;
    fadt->p_lvl3_lat = chip->c3_latency;
    fadt->flush_size = 0;
diff --git a/src/southbridge/intel/i82801ix/fadt.c b/src/southbridge/intel/i82801ix/fadt.c
index ff30611..0b0e7b4 100644
--- a/src/southbridge/intel/i82801ix/fadt.c
+++ b/src/southbridge/intel/i82801ix/fadt.c
@@ -12,14 +12,6 @@

fadt->sci_int = 0x9;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-		fadt->pstate_cnt = APM_CNT_PST_CONTROL;
-		fadt->cst_cnt = APM_CNT_CST_CONTROL;
-	}
-
    fadt->pm1a_evt_blk = pmbase;
    fadt->pm1b_evt_blk = 0x0;
    fadt->pm1a_cnt_blk = pmbase + 0x4;
diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c
index c704015..398b432 100644
--- a/src/southbridge/intel/i82801jx/lpc.c
+++ b/src/southbridge/intel/i82801jx/lpc.c
@@ -518,14 +518,6 @@

fadt->sci_int = 0x9;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-		fadt->cst_cnt = APM_CNT_CST_CONTROL;
-		fadt->pstate_cnt = APM_CNT_PST_CONTROL;
-	}
-
    fadt->p_lvl2_lat = 1;
    fadt->p_lvl3_lat = chip->c3_latency;
    fadt->flush_size = 0;
diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c
index 51db1f2..b89eccc 100644
--- a/src/southbridge/intel/ibexpeak/lpc.c
+++ b/src/southbridge/intel/ibexpeak/lpc.c
@@ -582,11 +582,6 @@

fadt->sci_int = 0x9;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}

fadt->pm1a_evt_blk = pmbase;
    fadt->pm1b_evt_blk = 0x0;
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index 782ecb5..a74f729 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -732,11 +732,6 @@

fadt->sci_int = 0x9;

-	if (permanent_smi_handler()) {
-		fadt->smi_cmd = APM_CNT;
-		fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-		fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
-	}

fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1b_evt_blk = 0x0;

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42034

to look at the new patch set (#2).

Change subject: [WIP] arch/x86: Consolidate ACPI FADT for SMI entries
......................................................................

[WIP] arch/x86: Consolidate ACPI FADT for SMI entries

Change-Id: Ia3c976b13508f0cbe4f494eb26c87031abaac459
Signed-off-by: Kyösti Mälkki 
---
M src/acpi/acpi.c
M src/cpu/x86/smm/smi_trigger.c
M src/include/acpi/acpi.h
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
M src/soc/intel/xeon_sp/cpx/acpi.c
M src/soc/intel/xeon_sp/skx/acpi.c
M src/southbridge/amd/agesa/hudson/fadt.c
M src/southbridge/amd/pi/hudson/fadt.c
M src/southbridge/intel/bd82x6x/lpc.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/i82801dx/fadt.c
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801ix/fadt.c
M src/southbridge/intel/i82801jx/lpc.c
M src/southbridge/intel/ibexpeak/lpc.c
M src/southbridge/intel/lynxpoint/lpc.c
22 files changed, 21 insertions(+), 119 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/42034/2

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42034

to look at the new patch set (#3).

Change subject: [WIP] arch/x86: Consolidate ACPI FADT for SMI entries
......................................................................

[WIP] arch/x86: Consolidate ACPI FADT for SMI entries

Change-Id: Ia3c976b13508f0cbe4f494eb26c87031abaac459
Signed-off-by: Kyösti Mälkki 
---
M src/acpi/acpi.c
M src/cpu/x86/smm/Makefile.inc
A src/cpu/x86/smm/smi_trigger.c
M src/include/acpi/acpi.h
M src/soc/amd/picasso/acpi.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/skylake/acpi.c
M src/soc/intel/xeon_sp/cpx/acpi.c
M src/soc/intel/xeon_sp/skx/acpi.c
M src/southbridge/amd/agesa/hudson/fadt.c
M src/southbridge/amd/pi/hudson/fadt.c
M src/southbridge/intel/bd82x6x/lpc.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/i82801dx/fadt.c
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801ix/fadt.c
M src/southbridge/intel/i82801jx/lpc.c
M src/southbridge/intel/ibexpeak/lpc.c
M src/southbridge/intel/lynxpoint/lpc.c
23 files changed, 22 insertions(+), 119 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/42034/3

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42034 )

Change subject: [WIP] arch/x86: Consolidate ACPI FADT for SMI entries
......................................................................

Abandoned