Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34784 )
Change subject: soc/mediatek: dsi: Refactor MIPI TX configuration
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34784/7/src/soc/mediatek/mt8173/inc...
File src/soc/mediatek/mt8173/include/soc/dsi.h:
https://review.coreboot.org/c/coreboot/+/34784/7/src/soc/mediatek/mt8173/inc...
PS7, Line 23: #define MTK_DSI_MIPI_RATIO_DENOMINATOR 100
These were recommended by MTK. I can double confirm this as follow up.
There was no complete FPS calculation in 8173 old implementation, so the calculation provided was using few hard-coded values, and that's why MIPI ratio was introduced, and should not be needed for 8183+.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I894dc2c4c053267debf5a58313b2bb489bcf5f3a
Gerrit-Change-Number: 34784
Gerrit-PatchSet: 8
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 03:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment