Attention is currently required from: Andrey Petrov, Ronak Kanabar.
Hello Andrey Petrov, Ronak Kanabar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80275?usp=email
to look at the new patch set (#2).
Change subject: drivers/intel/fsp2_0: Add FSP 2.4 support ......................................................................
drivers/intel/fsp2_0: Add FSP 2.4 support
Intel Firmware Support Package 2.4 specification brings some significant changes compared to version 2.3 (cf. documents 736809 and 644852 respectively):
1. It supports FSP-M multi-phase init. Some fields have been added to the FSP header data structure for this purpose.
2. The `FSPM_ARCH2_UPD' and `FSPS_ARCH2_UPD' data structures must be used in place of `FSPM_ARCH_UPD' and `FSPS_ARCH_UPD' respectively.
3. It supports 64-bits FSP:
- FSP functions must be called with the stack 16-bytes aligned. This is already setup properly with the default value of the `mpreferred-stack-boundary' compiler option (4).
- The FSP stack buffer supplied by coreboot through the `StackBase' UPD must be 16-bytes aligned.
A few notes:
- `PLATFORM_USES_FSP2_X86_32' is set to `n' by default if FSP 2.4 is enabled as 64-bits FSP should be norm moving forward.
- Similarly to what is done for silicon initialization, timestamps and post-codes are used during the memory initialization multi-phase. However, since post-codes are in short supply, memory and silicon multi-phase init share the same post-codes.
Change-Id: I1c24d26e105c3dcbd9cca0e7197ab1362344aa97 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/commonlib/include/commonlib/console/post_codes.h M src/commonlib/include/commonlib/timestamp_serialized.h M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/fsp2_0/include/fsp/util.h M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/intel/fsp2_0/silicon_init.c M util/cbfstool/eventlog.c 8 files changed, 126 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/80275/2