Attention is currently required from: Arthur Heymans, Christian Walter, Felix Singer, Patrick Rudolph, Paul Menzel, Tim Chu, Ziang Wang.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75740?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/xeon_sp/spr: Fix memory max capacity per processor
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/xeon_sp/spr/romstage.c:
https://review.coreboot.org/c/coreboot/+/75740/comment/1deb31ab_bea27793 :
PS1, Line 277: * Persistent Memory 300 Series mapped as memory) per Socket
I don't understand how to calculate anything from this. What is 3DS?
Is the 6TiB supposed to be the sum of max. DRAM and max. Optane Memory?
https://review.coreboot.org/c/coreboot/+/75740/comment/44fe88ae_3ce82165 :
PS1, Line 279: MiB
I guess this should be `(TiB/MiB)` (note there is already an MiB in
the struct field's name) which is the same value as `MiB` again by
coincidence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75740?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb892d3b148291b35808d634d63b58b90d456767
Gerrit-Change-Number: 75740
Gerrit-PatchSet: 1
Gerrit-Owner: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 09 Jun 2023 10:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment