[S] Change in coreboot[main]: google/chromeec: Add function to report the SKU ID

[Julius Werner (Code Review)]

Attention is currently required from: Aamir Bohra, Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eran Mitrani, Eric Lai, Hung-Te Lin, Jakub "Kuba" Czapiga, Jason Nien, Jayvik Desai, Kapil Porwal, Martin Roth, Nick Vaccaro, Paul Menzel, Pranava Y N, Subrata Banik, Subrata Banik, Tarun.

Julius Werner has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86810?usp=email )

Change subject: google/chromeec: Add function to report the SKU ID
......................................................................

Patch Set 12: Code-Review+1

(1 comment)

File src/ec/google/chromeec/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/86810/comment/836bf6cf_55c7b7d2?usp... :
PS12, Line 14: y
> if you need google_chromeec_get_board_sku for platform w/ EC_GOOGLE_CHROMEEC_SMBIOS, then you can move google_chromeec_get_board_sku api into ec_chrome.c

Whether we move the parts that are not supposed to be guarded by the Kconfig out into another file, or we remove the Kconfig switch from the file and instead introduce it as a CPP guard around one function, comes out to the same thing. I don't think there's anything wrong with the approach taken in this patch, it makes sense to keep both functions in that file because they're both related to SKU ID stuff (and it's nice when reading the code to get them both on one screen). Moving stuff that's guarded by a separate Kconfig out into a separate file sometimes makes sense, but there's no rule saying it must always be done that way — it comes down to the specific circumstances.