Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich.
Joel Bueno has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: mb/emulation/spike-riscv: Define default DRAM_SIZE to avoid crash
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85800/comment/64ddd060_c5657909?usp... :
PS3, Line 16: his does not happen on qemu because, for that target, we parse the
: FDT instead of manually probing memory.
I am not really familiar with spike, but I guess we can also parse an FDT from SPIKE? It would like […]
Yes, we have drafted a patch for it; would it be better for the coreboot team if we created a separate patch or should we just re-use this one?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Bueno
joel.bueno@openchip.com
Gerrit-Reviewer: Carlos López
carlos.lopezr4096@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 28 Jan 2025 10:22:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com