Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52872 )
Change subject: mb/google/cherry: Add NOR-Flash support
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/cherry/bootblock.c:
PS1:
Similar to Patrick's comment in CB:52668, could you split this into two patches: one for soc and the […]
Done
File src/soc/mediatek/mt8195/include/soc/symbols.h:
https://review.coreboot.org/c/coreboot/+/52872/comment/6a8675b9_a4eb159a
PS1, Line 9: 2
5
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I356e6b1cba3c078bf99e056b290476c7179e8ccf
Gerrit-Change-Number: 52872
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Comment-Date: Tue, 04 May 2021 02:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment