Attention is currently required from: Angel Pons, Jan Philipp Groß, Keith Hui, Máté Kukri, Nicholas Chin.
Felix Singer has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/85926?usp=email )
Change subject: mb/asrock: Add Z87 Extreme3 (Haswell)
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/mainboard/asrock/z87_extreme3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85926/comment/e3fcc128_4e7fcac9?usp... :
PS1, Line 15: pci 00.0
Please use device aliases and remove superfluous comments
File src/mainboard/asrock/z87_extreme3/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/85926/comment/b606f71d_127cb859?usp... :
PS1, Line 18: /* global NVS and variables. */
Remove superfluous comment
File src/mainboard/asrock/z87_extreme3/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/85926/comment/f051efd2_e39f0018?usp... :
PS1, Line 24:
remove blank line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85926?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c13c068d899588eda80b9957127bcb6ccf8bab0
Gerrit-Change-Number: 85926
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Máté Kukri
km@mkukri.xyz
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Máté Kukri
km@mkukri.xyz
Gerrit-Attention: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 10 Jan 2025 01:09:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes