Attention is currently required from: Felix Singer, Andy Pont, Michael Niewöhner. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60123 )
Change subject: mb/starlabs/labtop: Tidy up GPIOs ......................................................................
Patch Set 14:
(13 comments)
File src/mainboard/starlabs/labtop/variants/tgl/gpio.c:
https://review.coreboot.org/c/coreboot/+/60123/comment/1ffba142_abc16f8b PS2, Line 29: PAD_CFG_NF(GPD2, NATIVE, PWROK, NF1),
Disconnect
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/4b7b0f53_cfb8be5b PS2, Line 38: PAD_CFG_GPO(GPD11, 0, PWROK)
Disconnect
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/a3f000c2_c068e42b PS2, Line 64: PAD_CFG_GPO(GPP_B17, 0, PWROK),
Disconnect
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/2539ed4b_1de00790 PS2, Line 65: PAD_CFG_GPO(GPP_B18, 0, DEEP),
Disconnect
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/7487d888_301df1aa PS2, Line 73: PAD_CFG_GPO(GPP_B22, 0, DEEP),
Disconnect
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/29eb5330_948952ec PS2, Line 114: PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1),
PAD_CFG_GPI_APIC_LOW(GPP_C8, NONE, PLTRST),
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/2513ed69_684677d6 PS2, Line 182: /* REQ 0 */ PAD_NC(GPP_D5, NONE), : /* REQ 1 */ PAD_NC(GPP_D6, NONE), : /* REQ 2 */ PAD_NC(GPP_D7, NONE),
Not used
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/e3cbf5f1_91f0d603 PS2, Line 186: /* REQ 4 */ PAD_NC(GPP_H10, NONE), : /* REQ 5 */ PAD_NC(GPP_H11, NONE), : /* REQ 6 */ PAD_NC(GPP_F19, NONE),
Not used
Done
https://review.coreboot.org/c/coreboot/+/60123/comment/cffc4e8a_93a371e9 PS2, Line 346: PAD_CFG_TERM_GPO(GPP_D19, 1, UP_20K, DEEP),
Disconnect
Done
File src/mainboard/starlabs/labtop/variants/tgl/gpio.c:
https://review.coreboot.org/c/coreboot/+/60123/comment/7981021c_254ca9c2 PS11, Line 213: : PAD_CFG_NF(GPP_T2, DN_20K, DEEP, NF2), : PAD_CFG_NF(GPP_T3, DN_20K, DEEP, NF2), : PAD_NC(GPP_U4, NONE), : PAD_NC(GPP_U5, NONE),
Where did they go? Seems they are disappeared? Please do such changes in a separate commit.
Missed them, re-added now
https://review.coreboot.org/c/coreboot/+/60123/comment/4dc5a8aa_b05a76b2 PS11, Line 34: /* A7 --[ GPP_A7 ]-- WLAN_PCM_CLK */
The first two columns seems redundant. […]
Those comments match up to the schematic.
https://review.coreboot.org/c/coreboot/+/60123/comment/e1948278_3668ab61 PS11, Line 60: /* A20 --[ GPP_A20 ]-- Not Connected */
If a pad is NC, then this is apparent through the PAD_NC macro. […]
I'd prefer to leave the "Not Connected" comments, as that just means it says it's not connected in the schematic.
https://review.coreboot.org/c/coreboot/+/60123/comment/7a4b50cb_1b6bec04 PS11, Line 385: /* GPD0 --[ GPD0 ]-- PCH_BATLOW# */ : PAD_CFG_NF(GPD0, NONE, DEEP, NF1), : /* GPD1 --[ GPD1 ]-- AC_PRESENT */ : PAD_CFG_NF(GPD1, NONE, DEEP, NF1), : /* GPD2 --[ GPD2 ]-- LAN_WAKE# */ : PAD_NC(GPD2, NONE), : /* GPD3 --[ GPD3 ]-- SIO_PWRBTN# */ : PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), : /* GPD4 --[ GPD4 ]-- SIO_SLP_S3# */ : PAD_CFG_NF(GPD4, NONE, DEEP, NF1), : /* GPD5 --[ GPD5 ]-- SIO_SLP_S4# */ : PAD_CFG_NF(GPD5, NONE, DEEP, NF1), : /* GPD6 --[ GPD6 ]-- SIO_SLP_A# */ : PAD_CFG_NF(GPD6, NONE, DEEP, NF1), : /* GPD7 --[ GPD7 ]-- PCH_TBT_PERST# */ : PAD_CFG_GPO(GPD7, 0, PLTRST), : /* GPD8 --[ GPD8 ]-- SUSCLK */ : PAD_CFG_NF(GPD8, NONE, DEEP, NF1), : /* GPD9 --[ GPD9 ]-- SIO_SLP_WLAN# */ : PAD_CFG_NF(GPD9, NONE, DEEP, NF1), : /* GPD10--[ GPD10 ]-- SIO_SLP_S5# */ : PAD_CFG_NF(GPD10, NONE, DEEP, NF1), : /* GPD11--[ GPD11 ]-- PM_LANPHY_EN */ : PAD_CFG_NF(GPD11, NONE, DEEP, NF1),
These were at the beginning before. Move them in a separate commit.
Done
-
Sean Rhodes (Code Review)