Attention is currently required from: Martin Roth, Paul Fagerburg, Julius Werner, Jan Dabros.
jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50715 )
Change subject: tests: Add lib/malloc-test test case
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Overall LGTM. […]
What do you mean by that? Should I call memalign() with the same alignment value or a different one?
I also added address alignment checking for memalign() in two test cases. Maybe this will be sufficient?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6b10ec382cc807772689e852bad300c75da1fe2
Gerrit-Change-Number: 50715
Gerrit-PatchSet: 2
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Thu, 18 Feb 2021 09:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment