Change in coreboot[master]: amdfwtool: Add options to separate signed firmwares - coreboot-gerrit

21 Dec 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59866 )
Change subject: amdfwtool: Add options to separate signed firmwares
......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135998):
https://review.coreboot.org/c/coreboot/+/59866/comment/a1b21dcc_84f7f952 
PS3, Line 873: 				pspdir->entries[count].address_mode = SET_ADDR_MODE_BY_TABLE(pspdir);
line over 96 characters
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f3610a7002b2a9c70946b083b0b3be6934200b0
Gerrit-Change-Number: 59866
Gerrit-PatchSet: 3
Gerrit-Owner: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bao Zheng fishbaozi@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 22 Dec 2021 05:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment