Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46366 )
Change subject: soc/intel/broadwell: Fix copy-pasted copy-paste error ......................................................................
soc/intel/broadwell: Fix copy-pasted copy-paste error
The code with this error was copy-pasted from Haswell. It was fixed with commit dab81a4 (northbridge/intel/haswell: Fix copy paste error) for Haswell. Do the same for Broadwell. Given that LP SKUs only support one DIMM per channel, this change makes no difference in practice.
Change-Id: I2a7bee617354870aa4334b6c0e6b49d831e64c23 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/romstage/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/46366/1
diff --git a/src/soc/intel/broadwell/romstage/raminit.c b/src/soc/intel/broadwell/romstage/raminit.c index 00419fc..4977b35 100644 --- a/src/soc/intel/broadwell/romstage/raminit.c +++ b/src/soc/intel/broadwell/romstage/raminit.c @@ -61,7 +61,7 @@
printk(BIOS_DEBUG, " DIMMB %d MB width %s %s rank%s\n", ((ch_conf >> 8) & 0xff) * 256, - ((ch_conf >> 19) & 1) ? "x16" : "x8 or x32", + ((ch_conf >> 20) & 1) ? "x16" : "x8 or x32", ((ch_conf >> 18) & 1) ? "dual" : "single", ((ch_conf >> 16) & 1) ? ", selected" : ""); }
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46366 )
Change subject: soc/intel/broadwell: Fix copy-pasted copy-paste error ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46366 )
Change subject: soc/intel/broadwell: Fix copy-pasted copy-paste error ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46366/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46366/2//COMMIT_MSG@13 PS2, Line 13: Maybe add a Fixes tag with the commit introducing the error.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46366 )
Change subject: soc/intel/broadwell: Fix copy-pasted copy-paste error ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46366/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46366/2//COMMIT_MSG@13 PS2, Line 13:
Maybe add a Fixes tag with the commit introducing the error.
I don't think it matters much. It has been wrong since it was originally introduced.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46366 )
Change subject: soc/intel/broadwell: Fix copy-pasted copy-paste error ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46366 )
Change subject: soc/intel/broadwell: Fix copy-pasted copy-paste error ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46366/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46366/2//COMMIT_MSG@13 PS2, Line 13:
I don't think it matters much. It has been wrong since it was originally introduced.
Ack
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46366 )
Change subject: soc/intel/broadwell: Fix copy-pasted copy-paste error ......................................................................
soc/intel/broadwell: Fix copy-pasted copy-paste error
The code with this error was copy-pasted from Haswell. It was fixed with commit dab81a4 (northbridge/intel/haswell: Fix copy paste error) for Haswell. Do the same for Broadwell. Given that LP SKUs only support one DIMM per channel, this change makes no difference in practice.
Change-Id: I2a7bee617354870aa4334b6c0e6b49d831e64c23 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46366 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/soc/intel/broadwell/romstage/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/broadwell/romstage/raminit.c b/src/soc/intel/broadwell/romstage/raminit.c index 00419fc..4977b35 100644 --- a/src/soc/intel/broadwell/romstage/raminit.c +++ b/src/soc/intel/broadwell/romstage/raminit.c @@ -61,7 +61,7 @@
printk(BIOS_DEBUG, " DIMMB %d MB width %s %s rank%s\n", ((ch_conf >> 8) & 0xff) * 256, - ((ch_conf >> 19) & 1) ? "x16" : "x8 or x32", + ((ch_conf >> 20) & 1) ? "x16" : "x8 or x32", ((ch_conf >> 18) & 1) ? "dual" : "single", ((ch_conf >> 16) & 1) ? ", selected" : ""); }