Attention is currently required from: Anil Kumar K, Cliff Huang, Subrata Banik, Selma Bensaid.
Hello build bot (Jenkins), Anil Kumar K, Cliff Huang, Subrata Banik, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67212
to look at the new patch set (#2).
Change subject: mb/google/brya/acpi: Remove erroneous _PR0/_PR3 ......................................................................
mb/google/brya/acpi: Remove erroneous _PR0/_PR3
The Linux kernel runtime D3 framework expects a PCIe device to have a power resource in order to be properly power-manageable. The _PR0/_PR3 values were pointing at the PEG0 Device, which is not a PowerResource, so this must have confused the RTD3 framework and RTD3 was not functional. Removing the _PR0/_PR3 fixes the problem.
BUG=b:243888246 TEST=echo auto > /sys/bus/pci/devices/0000:01:00.0/power/control; sleep 10; echo on > /sys/bus/pci/devices/0000:01:00.0/power/control After this there are no longer errors seen in dmesg about failing to place the device into D0.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I83fa1e5fabd3257b097c10e7a13c9861872685ea --- M src/mainboard/google/brya/acpi/nvjt.asl M src/mainboard/google/brya/acpi/nvop.asl M src/mainboard/google/brya/acpi/power.asl 3 files changed, 32 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/67212/2