Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 )
Change subject: soc/amd/common/block/apob: Add hashed APOB support
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67301/comment/f22ea7ab_95955ddf
PS4, Line 15: chausie
I don't have a guybrush to test with. […]
I'm sure you could easily get one ;)
I suspect it won't. `PSP_APOB_DRAM_SIZE` is defined as 64K, and the `RW_MRC_CACHE` is defined as 64K as well. I'm not sure what `apob_header_ptr->size` actually contains though. If it was smaller then the 64K it might work.
File src/soc/amd/common/block/apob/apob_cache.c:
https://review.coreboot.org/c/coreboot/+/67301/comment/78e93186_0c924fa8
PS4, Line 57: apob_header_ptr->size + MRC_HASH_SIZE
If this check fails, the device can still boot. The actual size is not known at compile time. […]
We know this via `CONFIG_PSP_APOB_DRAM_SIZE` don't we?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba
Gerrit-Change-Number: 67301
Gerrit-PatchSet: 5
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Sep 2022 18:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment