Attention is currently required from: Anil Kumar K, Dinesh Gehlot, Eran Mitrani, Jérémy Compostella, Kapil Porwal, Martin L Roth, Martin Roth, Shelley Chen, Subrata Banik, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78244?usp=email )
Change subject: soc/intel/mtl: Display Sign-of-Life message using FSP-M
......................................................................
Patch Set 23:
(6 comments)
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/78244/comment/54714ab9_bec00689 :
PS23, Line 463: depends on MAINBOARD_HAS_CHROMEOS
Why this dependency?
https://review.coreboot.org/c/coreboot/+/78244/comment/4bced432_e343a582 :
PS23, Line 464: select VBT_CBFS_COMPRESSION_DEFAULT_LZ4
Why?
https://review.coreboot.org/c/coreboot/+/78244/comment/7fd59793_b3223bad :
PS23, Line 466: which display
1. which display*s*
2. … to display …
https://review.coreboot.org/c/coreboot/+/78244/comment/ab8eb02b_1ca10f03 :
PS23, Line 467: Memory
memory
https://review.coreboot.org/c/coreboot/+/78244/comment/cfa935da_60c29a07 :
PS23, Line 467: configurable text message
Where can this be configured?
https://review.coreboot.org/c/coreboot/+/78244/comment/8641fbd7_8f52f49d :
PS23, Line 468: and CSME update.
It’d be nice, if you added as much information how the FSP-M graphics init works either here in the help text or the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78244?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8e7772582b1895fa8e38780932346683be998558
Gerrit-Change-Number: 78244
Gerrit-PatchSet: 23
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 29 Nov 2023 09:44:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment