Attention is currently required from: Angel Pons, Michael Niewöhner. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49464 )
Change subject: mb/purism/librem_cnl: Update HDA verbs for Librem Mini ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49464/comment/399b5156_848d4e60 PS1, Line 13: verb.
nit: place on the next line
Done
File src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/49464/comment/41df480e_02147b0d PS1, Line 27: AZALIA_PIN_CFG(2, 0x05, 0x18560010), : AZALIA_PIN_CFG(2, 0x06, 0x18560010), : AZALIA_PIN_CFG(2, 0x07, 0x18560010),
What was wrong with the original values?
all I changed was the group number (as noted in commit msg), to be consistent with the value used in ever vendor firmware dump I've seen in the past few years