Attention is currently required from: Martin Roth, Julius Werner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51673 )
Change subject: [POC]lint: Add alphabetical sorting check ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: This was a lot easier than I thought... the best place to hook it up would be checkpatch. So somebody would have to translate it to perl. But with the current form, the logic is tested / has proven itself ;)
An actual linter is out of the question because those are sup- posed to be always right. But include order, for instance, may matter in corner cases.
Checking new lists for alphabetical order too turned out to be even one line simpler. But I'm not a fan of it, actually.
I manually checked for false positives in:
$ time git log --format= --no-prefix -p -U32 4.13..HEAD | awk -f util/lint/alphabetical.awk
(the first hit is rather ironic ^^)
-
Nico Huber (Code Review)