Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69817 )
Change subject: src/commonlib: Remove unnecessary space after casts ......................................................................
src/commonlib: Remove unnecessary space after casts
Change-Id: Ib20f02cc9e5be0efea8bc29fce6bd148adf28ead Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/commonlib/fsp_relocate.c M src/commonlib/storage/bouncebuf.h M src/commonlib/storage/sdhci_adma.c M src/commonlib/storage/storage.h 4 files changed, 16 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/69817/1
diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index 55295ca..ad24ca7 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -233,13 +233,13 @@ uint32_t i; EFI_IMAGE_DATA_DIRECTORY *relocd;
- relocd = (void *) &pe_base[offset]; + relocd = (void *)&pe_base[offset]; offset += sizeof(*relocd); // Read relocation type, offset pairs rlen = read_le32(&relocd->Size) - sizeof(*relocd); rnum = rlen / sizeof(uint16_t); vaddr = read_le32(&relocd->VirtualAddress); - rdata = (uint16_t *) &pe_base[offset]; + rdata = (uint16_t *)&pe_base[offset]; printk(FSP_DBG_LVL, "\t%d Relocs for RVA %x\n", rnum, vaddr);
for (i = 0; i < rnum; i++) { diff --git a/src/commonlib/storage/bouncebuf.h b/src/commonlib/storage/bouncebuf.h index 9e3ab74..fce3fbd 100644 --- a/src/commonlib/storage/bouncebuf.h +++ b/src/commonlib/storage/bouncebuf.h @@ -76,7 +76,7 @@ #define ALLOC_CACHE_ALIGN_BUFFER(type, name, size) \ char __##name[ROUND(size * sizeof(type), DMA_MINALIGN) + \ DMA_MINALIGN - 1]; \ - type *name = (type *) ALIGN_UP((uintptr_t)__##name, DMA_MINALIGN) + type *name = (type *)ALIGN_UP((uintptr_t)__##name, DMA_MINALIGN) #ifndef ARCH_DMA_MINALIGN #define ARCH_DMA_MINALIGN (DMA_MINALIGN) #endif diff --git a/src/commonlib/storage/sdhci_adma.c b/src/commonlib/storage/sdhci_adma.c index 92f938f..9ad949e 100644 --- a/src/commonlib/storage/sdhci_adma.c +++ b/src/commonlib/storage/sdhci_adma.c @@ -120,10 +120,10 @@ }
if (dma64) - sdhci_writel(sdhci_ctrlr, (uintptr_t) sdhci_ctrlr->adma64_descs, + sdhci_writel(sdhci_ctrlr, (uintptr_t)sdhci_ctrlr->adma64_descs, SDHCI_ADMA_ADDRESS); else - sdhci_writel(sdhci_ctrlr, (uintptr_t) sdhci_ctrlr->adma_descs, + sdhci_writel(sdhci_ctrlr, (uintptr_t)sdhci_ctrlr->adma_descs, SDHCI_ADMA_ADDRESS);
return 0; diff --git a/src/commonlib/storage/storage.h b/src/commonlib/storage/storage.h index cdd5e6c..5f51ba9 100644 --- a/src/commonlib/storage/storage.h +++ b/src/commonlib/storage/storage.h @@ -11,7 +11,7 @@ #define ALLOC_CACHE_ALIGN_BUFFER(type, name, size) \ char __##name[ROUND(size * sizeof(type), DMA_MINALIGN) + \ DMA_MINALIGN - 1]; \ - type *name = (type *) ALIGN_UP((uintptr_t)__##name, DMA_MINALIGN) + type *name = (type *)ALIGN_UP((uintptr_t)__##name, DMA_MINALIGN)
/* NOOPs mirroring ARM's cache API, since x86 devices usually cache snoop */ #define dcache_invalidate_by_mva(addr, len)