Attention is currently required from: Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58188 )
Change subject: nb/intel/sandybridge: Populate meminfo when using MRC ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
what is build_timeless and why would the image be the same if the 2 files those code were not added in before and after ?
Building coreboot with `make BUILD_TIMELESS=1` produces a coreboot.rom that is meant to be reproducible, as it doesn't contain stuff like version information or build time. Reproducible coreboot images can be compared using `diff`, which is useful in some cases to ensure commits don't alter the behavior of the code.
For example, CB:58902 rewrites the HDA configuration for Broadwell-based Purism Librem laptops using macros, but the coreboot.rom doesn't change after the rewrite. This means the rewritten settings exactly correspond to the original settings, so the commit can't cause any issues.
In this commit, `raminit_mrc.c` is not compiled in when using native raminit, and the change to `raminit.h` doesn't have any effect (it's just an unused declaration). This is why the coreboot.rom doesn't change.
-
Angel Pons (Code Review)