Attention is currently required from: Furquan Shaikh, Philipp Hug, Patrick Rudolph, Christian Walter, Julius Werner, Aaron Durbin, ron minnich.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50967 )
Change subject: CBMEM: cbmem_initialize() in romstage is always _empty()
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I agree with the direction of this patch series, but as it changes API semantics, let's give it anot […]
CB:50987 is related.
Not under review yet, but I will suggest to replace romstage_handoff with a compulsory chipset_power_state initialised early in romstage, for platforms with ACPI S3 support.
Also, I don't see much value in having the separation of CBMEM hooks per stage, we can achieve the same with use of 'if (ENV_xx)' or better use of the is_recovery -parameter.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04aeefa7abac1d559a1f41303842ec05d7251064
Gerrit-Change-Number: 50967
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 22 Feb 2021 08:30:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment