Change in coreboot[master]: util/bucts: Add tool to manipulate BUC.TS bit on Intel targets
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18224 )
Change subject: util/bucts: Add tool to manipulate BUC.TS bit on Intel targets ......................................................................
Patch Set 5:
(18 comments)
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c File util/bucts/bucts.c:
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@31 PS5, Line 31: #if defined (__sun) && (defined(__i386) || defined(__amd64)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@75 PS5, Line 75: return MAP_FAILED == virt_addr ? NULL : virt_addr; Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@113 PS5, Line 113: if (EINVAL == errno) { Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@131 PS5, Line 131: static int get_platform_info(struct pci_dev *sb, int *has_var_bb, uint32_t *rcba_addr) line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@238 PS5, Line 238: int spi_is_bootdevice = ((*(uint16_t *)(rcba + GCS_OFFSET) >> 10) & 3) == 3; line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@241 PS5, Line 241: *(uint32_t *)(rcba + SPIBAR + FDOC) = (PCHSTRAPS_SECTION << 12) | 0; line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@262 PS5, Line 262: ? "set, changing top swap not possible" : "unset, changing top swap is possible"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@263 PS5, Line 263: printf("Top Swap : %s\n", ts ? "Enabled" : "Disabled"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@266 PS5, Line 266: printf("Ranges swapped : 0x%llx-0x%08llx <-> 0x%08llx-0x%08llx", line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@289 PS5, Line 289: printf("BIOS Interface Lock-Down set, Changing Top Swap not possible.\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@342 PS5, Line 342: printf("Invalid setting: multiple set/unset arguments\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@346 PS5, Line 346: printf("Print and Set are mutually exclusive!\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@354 PS5, Line 354: printf("Invalid setting: multiple set/unset arguments\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@358 PS5, Line 358: printf("Print and Set are mutually exclusive!\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@366 PS5, Line 366: printf("Print and Set are mutually exclusive!\n"); line over 80 characters
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@375 PS5, Line 375: default: Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@389 PS5, Line 389: if ((io_fd = open("/dev/io", O_RDWR)) < 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@399 PS5, Line 399: if (-1 == (fd_mem = open(MEM_DEV, O_RDWR | O_SYNC))) { do not use assignment in if condition
-
build bot (Jenkins) (Code Review)