Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42745 )
Change subject: soc/intel: Configure PAVP at compile-time ......................................................................
Patch Set 13: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/42745/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/13//COMMIT_MSG@11 PS13, Line 11: multimedia content) to Kconfig. Maybe mention that it was hard enabled and this adds the option to disable it?
https://review.coreboot.org/c/coreboot/+/42745/13/src/soc/intel/common/Kconf... File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/42745/13/src/soc/intel/common/Kconf... PS13, Line 43: the Management Engine, which is where this technology is implemented. I would also recommend to disable it if one likes coreboot in general. I suspect that it's because of DRM technology that Intel is so closed about their chips these days. Hence my thought: DRM tech => worse coreboot support (and definitely less fun writing coreboot).
-
Nico Huber (Code Review)