Attention is currently required from: Jon Murphy.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 )
Change subject: mb/google/myst: Enable chromeOS EC ......................................................................
Patch Set 4: Verified+1
(2 comments)
File src/mainboard/google/myst/variants/baseboard/include/baseboard/ec.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172953): https://review.coreboot.org/c/coreboot/+/74099/comment/a9159926_5daf8bfd PS4, Line 70: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172953): https://review.coreboot.org/c/coreboot/+/74099/comment/2a6ebc23_f00f3d04 PS4, Line 70: #define SIO_EC_PS2K_IRQ Interrupt (ResourceConsumer, Level, ActiveLow, Shared) {1} Macros with complex values should be enclosed in parentheses