[XS] Change in coreboot[main]: commonlib/device_tree: Return cells properties of parent node

[Maximilian Brune (Code Review)]

Attention is currently required from: Julius Werner, Yu-Ping Wu.

Maximilian Brune has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/85964?usp=email )

Change subject: commonlib/device_tree: Return cells properties of parent node
......................................................................

Patch Set 1:

(1 comment)

File src/commonlib/device_tree.c:

https://review.coreboot.org/c/coreboot/+/85964/comment/263ac40a_5fb55477?usp... :
PS1, Line 1061:
> It worries me at least slightly that if a caller directly calls the base case (AKA path points to an […]

path is not allowed to be `NULL`. At the very least it must be `{ NULL }`.

calling `dt_find_node` with `path` as `NULL` would cause a NULL pointer deference down below.

You can call directly call `dt_find_node` with `path = { NULL }` but it is useless because it just returns the node that was supplied to the function (so you are basically asking the function to find the node that you supplied to it as `parent`).

In any case `addrcp` and `sizecp` shouldn't be an issue.