Attention is currently required from: Subrata Banik, Sridhar Siricilla. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62272 )
Change subject: soc/intel/alder lake: Send EOP early in the boot sequence ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62272/comment/98378fc9_9bcb625d PS2, Line 7: adl
alder lake
Done
https://review.coreboot.org/c/coreboot/+/62272/comment/a9c4167a_4bda51ef PS2, Line 9: Earlier
consider to better rephrase this to define the problem and highlight this CL as solution. […]
Ack
https://review.coreboot.org/c/coreboot/+/62272/comment/36d5eaf6_167c1ba4 PS2, Line 21: 20 ms
Note: last time when we implemented EOP is later stage (CB:57806), the time that I have recorded was […]
Agreed Subrata. Currently this is the best place as per our experiment and also as per trace analysis. We're also working with internal teams to see how we can optimize this communication to reduce overall EOP timing.
File src/soc/intel/alderlake/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/62272/comment/e7dc9564_72ac85bf PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
IMO, we don't need new file, if you follow this […]
Done
https://review.coreboot.org/c/coreboot/+/62272/comment/93b0e4b0_a5853ab0 PS2, Line 21: BOOT_STATE_INIT_ENTRY
Can we avoid adding more into boot stage and add this call directly into soc_init_pre_device(), post […]
Ack
-
Maulik V Vaghela (Code Review)