Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44048 )
Change subject: mb/ocp/deltalake: configure DIMM_MAX ......................................................................
mb/ocp/deltalake: configure DIMM_MAX
DeltaLake is a single socket server. Its platform design has 1 DIMM slot per channel. There are 6 DIMM slots.
Configure DIMM_MAX to overwrite SOC default.
Change-Id: I47ecc81452fe59ed59fd3a239ffe329cbc031d7a Signed-off-by: Jonathan Zhang jonzhang@fb.com --- M src/mainboard/ocp/deltalake/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/44048/1
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index 17f81bd..c65fa50 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -41,4 +41,9 @@ string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"
+# Deltalake is singel socket sever, the platform design has 1 DIMM per channel +config DIMM_MAX + int + default 6 + endif # BOARD_OCP_DELTALAKE
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44048 )
Change subject: mb/ocp/deltalake: configure DIMM_MAX ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44048/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/44048/1/src/mainboard/ocp/deltalake... PS1, Line 44: singel single
https://review.coreboot.org/c/coreboot/+/44048/1/src/mainboard/ocp/deltalake... PS1, Line 44: sever server
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44048 )
Change subject: mb/ocp/deltalake: configure DIMM_MAX ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44048/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/44048/1/src/mainboard/ocp/deltalake... PS1, Line 44: singel
single
Done
https://review.coreboot.org/c/coreboot/+/44048/1/src/mainboard/ocp/deltalake... PS1, Line 44: sever
server
Done
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44048
to look at the new patch set (#2).
Change subject: mb/ocp/deltalake: configure DIMM_MAX ......................................................................
mb/ocp/deltalake: configure DIMM_MAX
DeltaLake is a single socket server. Its platform design has 1 DIMM slot per channel. There are 6 DIMM slots.
Configure DIMM_MAX to overwrite SOC default.
Change-Id: I47ecc81452fe59ed59fd3a239ffe329cbc031d7a Signed-off-by: Jonathan Zhang jonzhang@fb.com --- M src/mainboard/ocp/deltalake/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/44048/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44048 )
Change subject: mb/ocp/deltalake: configure DIMM_MAX ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44048 )
Change subject: mb/ocp/deltalake: configure DIMM_MAX ......................................................................
mb/ocp/deltalake: configure DIMM_MAX
DeltaLake is a single socket server. Its platform design has 1 DIMM slot per channel. There are 6 DIMM slots.
Configure DIMM_MAX to overwrite SOC default.
Change-Id: I47ecc81452fe59ed59fd3a239ffe329cbc031d7a Signed-off-by: Jonathan Zhang jonzhang@fb.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44048 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/ocp/deltalake/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index d5df902..8897b9f 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -42,4 +42,9 @@ string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"
+# Deltalake is single socket server, the platform design has 1 DIMM per channel +config DIMM_MAX + int + default 6 + endif # BOARD_OCP_DELTALAKE
-
Angel Pons (Code Review) -
Jonathan Zhang (Code Review)