Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46770 )
Change subject: mb/google/volteer: correct memory id for elemi ......................................................................
mb/google/volteer: correct memory id for elemi
BUG=170604353 BRANCH=volteer TEST=emerge-volteer coreboot, and boot into kernel.
Change-Id: If354aa158f3ad60193268f38278a44f9c99bf3db --- M src/mainboard/google/volteer/variants/elemi/memory.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/46770/1
diff --git a/src/mainboard/google/volteer/variants/elemi/memory.c b/src/mainboard/google/volteer/variants/elemi/memory.c index d3de4be..32b7abc 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory.c +++ b/src/mainboard/google/volteer/variants/elemi/memory.c @@ -21,10 +21,10 @@ int variant_memory_sku(void) { gpio_t spd_gpios[] = { - GPIO_MEM_CONFIG_3, - GPIO_MEM_CONFIG_2, - GPIO_MEM_CONFIG_1, GPIO_MEM_CONFIG_0, + GPIO_MEM_CONFIG_1, + GPIO_MEM_CONFIG_2, + GPIO_MEM_CONFIG_3, };
return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios));
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46770
to look at the new patch set (#2).
Change subject: mb/google/volteer: correct memory id for elemi ......................................................................
mb/google/volteer: correct memory id for elemi
BUG=170604353 BRANCH=volteer TEST=emerge-volteer coreboot, and boot into kernel.
Change-Id: If354aa158f3ad60193268f38278a44f9c99bf3db Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/volteer/variants/elemi/memory.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/46770/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46770 )
Change subject: mb/google/volteer: correct memory id for elemi ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46770/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46770/2//COMMIT_MSG@9 PS2, Line 9: 170604353 b:170604353
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46770
to look at the new patch set (#3).
Change subject: mb/google/volteer: correct memory id for elemi ......................................................................
mb/google/volteer: correct memory id for elemi
BUG=b:170604353 BRANCH=volteer TEST=emerge-volteer coreboot, and boot into kernel.
Change-Id: If354aa158f3ad60193268f38278a44f9c99bf3db Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/volteer/variants/elemi/memory.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/46770/3
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46770 )
Change subject: mb/google/volteer: correct memory id for elemi ......................................................................
Patch Set 3: Code-Review+2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46770 )
Change subject: mb/google/volteer: correct memory id for elemi ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46770/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46770/2//COMMIT_MSG@9 PS2, Line 9: 170604353
b:170604353
Done
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46770 )
Change subject: mb/google/volteer: correct memory id for elemi ......................................................................
mb/google/volteer: correct memory id for elemi
BUG=b:170604353 BRANCH=volteer TEST=emerge-volteer coreboot, and boot into kernel.
Change-Id: If354aa158f3ad60193268f38278a44f9c99bf3db Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46770 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/elemi/memory.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/elemi/memory.c b/src/mainboard/google/volteer/variants/elemi/memory.c index d3de4be..32b7abc 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory.c +++ b/src/mainboard/google/volteer/variants/elemi/memory.c @@ -21,10 +21,10 @@ int variant_memory_sku(void) { gpio_t spd_gpios[] = { - GPIO_MEM_CONFIG_3, - GPIO_MEM_CONFIG_2, - GPIO_MEM_CONFIG_1, GPIO_MEM_CONFIG_0, + GPIO_MEM_CONFIG_1, + GPIO_MEM_CONFIG_2, + GPIO_MEM_CONFIG_3, };
return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios));
-
Chen Wisley (Code Review) -
Tim Wawrzynczak (Code Review)