Change in coreboot[master]: mb/google/soraka: Set psys_max to 45W - coreboot-gerrit

15 Feb 2018


      Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/23757 )
Change subject: mb/google/soraka: Set psys_max to 45W
......................................................................
Patch Set 5:
...
...
This should apply to all poppy derivatives, not just soraka.
Otherwise LGTM if the PSYS value matches values from the battery.
I agree with you but I don't have exact data about other variants.
Can you please help confirm ? I Assume its 45W
All poppy derivatives use the same 45W scale (that is, they use the same resistor on PSYS to turn the current source into voltage).
-- 
To view, visit https://review.coreboot.org/23757
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6f624733830b462329b5f539c20e2aea664143e
Gerrit-Change-Number: 23757
Gerrit-PatchSet: 5
Gerrit-Owner: Naresh Solanki naresh.solanki@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Naresh Solanki naresh.solanki@intel.com
Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Feb 2018 08:27:26 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No