Change in coreboot[master]: util/crossgcc: Ignore TLS certificate issues

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

util/crossgcc: Ignore TLS certificate issues

We have our own hashes to check, so while https is
nice to improve the chance of things going over the
wire unadulterated, we don't rely on it.

Change-Id: Id6ebb301775e1279b3c00e5064491c8f88be73ef
Signed-off-by: Patrick Georgi 
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/47935/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 01c4f86..3e618c3 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -1066,7 +1066,7 @@
    download_showing_percentage() {
    	url=$1
    	echo
-		curl -O --progress-bar --location --retry 3 "$url"
+		curl -O --insecure --progress-bar --location --retry 3 "$url"
    }
 fi

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

util/crossgcc: Ignore TLS certificate issues

We have our own hashes to check, so while https is
nice to improve the chance of things going over the
wire unadulterated, we don't rely on it.

Change-Id: Id6ebb301775e1279b3c00e5064491c8f88be73ef
Signed-off-by: Patrick Georgi 
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/47935/2

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

Patch Set 2: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

Patch Set 2:

Nico, adding you for review because you proposed something along these lines on IRC

[Mariusz Szafrański (Code Review)]

Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

Patch Set 3: Code-Review+1

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

IIRC, we were well aware that we do the hash checks anyway, and
the reason to move to https was to make sure that no adversary
can see the full URL (at least that's the only argument I remember
that technically made sense). We'd lose that this way.

Honestly, I don't care. An alternative would be to offer to try
again without certificate checks in case of failure, so the user
would have a choice.

https://review.coreboot.org/c/coreboot/+/47935/3/util/crossgcc/buildgcc 
File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/47935/3/util/crossgcc/buildgcc@1060 
PS3, Line 1060: 		wget --tries=3 "$url" 2>&1 | while read -r line; do
Should we add `--no-check-certificate` here?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

Patch Set 4: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47935 )

Change subject: util/crossgcc: Ignore TLS certificate issues
......................................................................

Abandoned